Uploaded image for project: 'Cloud Enablement'
  1. Cloud Enablement
  2. CLOUD-879

[IPS][RDS] evil use of eval in kieserver-config.sh

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • KIESRV63 1.4.0.GA
    • None
    • BPMS, BRMS
    • None
    • Hide

      Create an IPS or DS build with an empty KIE_CONTAINER_DEPLOYMENT, and two kjars with a dash in their artifactIds, (e.g. hello-world-1.0-SNAPSHOT.jar and hello-world-1.1-SNAPSHOT.jar )

      Show
      Create an IPS or DS build with an empty KIE_CONTAINER_DEPLOYMENT, and two kjars with a dash in their artifactIds, (e.g. hello-world-1.0-SNAPSHOT.jar and hello-world-1.1-SNAPSHOT.jar )
    • CLOUD Maintenance Sprint 1

      Having two kjars in deployments/ with "-" in their artifactId, and an empty KIE_CONTAINER_DEPLOYMENT env.

      The resulting KIE_CONTAINER_DEPLOYMENT will be

      KIE_CONTAINER_DEPLOYMENT: hello-world=com.redhat.xpaas.brms:hello-world:1.0-SNAPSHOT|hello-world=com.redhat.xpaas.brms:hello-world:1.1-SNAPSHOT
      

      however, there is a suspicous line in the build logs

      E0810 11:35:35.174844       1 util.go:91] /opt/eap/bin/kieserver-config.sh: line 85: hello-world=com.redhat.xpaas.brms:hello-world:1.1-SNAPSHOT: command not found
      

      The eval in question seem to evaluate the | as a shell pipe, which fails in this case, but is never correct anyway.

      eval should not be used to set env variables.

      Also the fact that the whole build works despite this issue suggests that part of the script is probably wrong.

            buschv Vanessa Busch
            maschmid@redhat.com Marek Schmidt
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 3 days
                3d
                Remaining:
                Remaining Estimate - 3 days
                3d
                Logged:
                Time Spent - Not Specified
                Not Specified