Uploaded image for project: 'Cloud Enablement'
  1. Cloud Enablement
  2. CLOUD-1945

Initial state of standalone-openshift.xml should be valid XML

    Details

      Description

      For JBoss Fuse on EAP we have an installer which manipulates the EAP configuration XML files in $JBOSS_HOME/standalone/configuration. I'd like to use it to create a Fuse EAP OpenShift image.

      With the EAP 7 (and 7.1) OpenShift image, there are various placeholders within standalone-openshift.xml. Most of them are XML commented within elements. However we have:

      <default-bindings context-service="java:jboss/ee/concurrency/context/default"
      <!-- ##DEFAULT_DATASOURCE## -->
      ##DEFAULT_JMS##
      managed-executor-service="java:jboss/ee/concurrency/executor/default"
      managed-scheduled-executor-service="java:jboss/ee/concurrency/scheduler/default"
      managed-thread-factory="java:jboss/ee/concurrency/factory/default"/>
      

      Having placeholders within tag content is not valid XML, so the Fuse installer complains when it attempts to manipulate the file:

      Error: Error on line 171 of document file:/opt/eap/standalone/configuration/standalone-openshift.xml: Element type "default-bindings" must be followed by either attribute specifications, ">" or "/>".
      org.jdom.input.JDOMParseException: Error on line 171 of document file:/opt/eap/standalone/configuration/standalone-openshift.xml: Element type "default-bindings" must be followed by either attribute specifications, ">" or "/>".
              at org.jdom.input.SAXBuilder.build(SAXBuilder.java:530)
              at org.jdom.input.SAXBuilder.build(SAXBuilder.java:905)
              at org.wildfly.extras.config.ConfigSupport.applyConfigurationChanges(ConfigSupport.java:265)
              at org.wildfly.extras.config.ConfigSupport.applyConfigChange(ConfigSupport.java:95)
              at org.wildfly.extras.config.internal.Main.mainInternal(Main.java:58)
              at org.wildfly.extras.config.internal.Main.main(Main.java:35)
              at org.jboss.modules.Module.run(Module.java:344)
              at org.jboss.modules.Main.main(Main.java:519)
      Caused by: org.xml.sax.SAXParseException; systemId: file:/opt/eap/standalone/configuration/standalone-openshift.xml; lineNumber: 171; columnNumber: 31; Element type "default-bindings" must be followed by either attribute specifications, ">" or "/>".
      

      Can we rethink how these placeholder values work? Perhaps turning them into dummy attribute values for default-bindings so that the XML stays valid?

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  luck3y Ken Wills
                  Reporter:
                  jamesnetherton James Netherton
                  Tester:
                  Marek Schmidt
                • Votes:
                  1 Vote for this issue
                  Watchers:
                  8 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: