• Icon: Sub-task Sub-task
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • ---
    • ---
    • CLID Sprint 252

      Overview

      Ensure that the current v2 respects the v1 TargetCatalog and TargetTag fields (if set) for oci catalog and registry catalogs.

      Also TargetCatalog and TargetTag should not be mutually exclusive.

      Invalid example:

      kind: ImageSetConfiguration
      apiVersion: mirror.openshift.io/v1alpha2
      mirror:
        operators:
        - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.14
          targetCatalog: abc/def:v5.5
          packages:
          - name: aws-load-balancer-operator

      Valid example:

      kind: ImageSetConfiguration
      apiVersion: mirror.openshift.io/v1alpha2
      mirror:
        operators:
        - catalog: registry.redhat.io/redhat/redhat-operator-index:v4.14
          targetCatalog: abc/def
          targetTag: v4.4
          packages:
          - name: aws-load-balancer-operator

            [CLID-47] TargetCatalog and TargetTag

            Rama Kasturi Narra added a comment - - edited

            skhoury@redhat.com yeah, that should be enough... yinzhou@redhat.com we might need to add new tests for v2 for these targetCatalog and targetTag

            Rama Kasturi Narra added a comment - - edited skhoury@redhat.com yeah, that should be enough... yinzhou@redhat.com we might need to add new tests for v2 for these targetCatalog and targetTag

            will take a look at it, thank you !!

            Rama Kasturi Narra added a comment - will take a look at it, thank you !!

            Hi knarra@redhat.com 
            let me know if the description in the PR is ok to start with. (https://github.com/openshift/oc-mirror/pull/827)

            especially, take a look at valid and invalid configurations.

            PS : rhn-support-stk  this might require to be double checked. adding this to the list in your v2 google doc

            Sherine Khoury added a comment - Hi knarra@redhat.com   let me know if the description in the PR is ok to start with. ( https://github.com/openshift/oc-mirror/pull/827) especially, take a look at valid and invalid configurations. PS : rhn-support-stk   this might require to be double checked. adding this to the list in your v2 google doc

            Rama Kasturi Narra added a comment - - edited

            thanks for letting us know !! skhoury@redhat.com are the changes captured anywhere for us to go through ?

            Rama Kasturi Narra added a comment - - edited thanks for letting us know !! skhoury@redhat.com are the changes captured anywhere for us to go through ?

            yingzhou@redhat.com knarra@redhat.com 

            After a discussion with jhunkins@redhat.com , we're fixing (in v2) the behavior of targetCatalog and targetTag.

            This may impact your existing tests.

            Sherine Khoury added a comment - yingzhou@redhat.com knarra@redhat.com   After a discussion with jhunkins@redhat.com , we're fixing (in v2) the behavior of targetCatalog and targetTag. This may impact your existing tests.

              skhoury@redhat.com Sherine Khoury
              luzuccar@redhat.com Luigi Mario Zuccarelli
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: