-
Task
-
Resolution: Done
-
Major
-
None
-
None
-
September sprint
-
5
JIRA workflow changes:
- Pull Request Sent
- Closed > Done when on portal
- Closed > reason if won't do
- "no_cp_impact" won't go to portal
Emily Murphy's suggestions:
I just went through the process for the second time, and it was much smoother this time. Your instructions are very good, and the side bars, warnings, etc.. are great. Just a few suggestions, below.
2.5
2. Create a pull request for the working branch in your fork to be merged with the preliminary target branch in your fork that you created.
Sugguestion:
Click the Pull requests tab, then click New pull request to create a pull request for the working branch in your fork to be merged with the preliminary target branch in your fork that you created.
Or whatever you think is best/most direct. I know my suggestion is verbose. But I floundered around for awhile before I found where to create a PR.
2. $ git push --set-upstream origin/BXMSDOC-1433-7.3.x-final
Should be:
$ git push --set-upstream origin BXMSDOC-1433-7.3.x-final
(no /)
6.
$ git checkout BXMSDOC-1433-7.3.x-final
$ git cherry-pick 971aee7 -m 1
$ git push
Should we say to build and check the output before pushing?