Uploaded image for project: 'OpenShift Builds'
  1. OpenShift Builds
  2. BUILD-897

Handle deletion of roles for webhook deployment

XMLWordPrintable

    • Builds Sprint #2261, Builds Sprint #3, Builds Sprint #4, Builds Sprint #5

      Story (Required)

      As a cluster admin trying to upgrade Shipwright to v0.13.0 I want the operator to handle the deletion of the webhook cluster roles

      Upstream Issue:  https://github.com/shipwright-io/operator/issues/181

      <Describes high level purpose and goal for this story. Answers the questions: Who is impacted, what is it and why do we need it? How does it improve the customer's experience?>

      Background (Required)

      <Describes the context or background related to this story>

      A cluster role and rolebinding for the conversion webhook was removed in v0.13.0. The operator should deploy v0.13.0, and after doing so check if these unnecessary resources are still present. If they are, delete them.

      See upstream release blog

      Out of scope

      <Defines what is not included in this story>

      • Ensuring Build API objects are migrated from the alpha to the beta API in storage.
      • Verifying this behavior works downstream. Will be addressed later as part of the downstream operator work.

      Approach (Required)

      <Description of the general technical path on how to achieve the goal of the story. Include details like json schema, class definitions>

      1. Update the operator to deploy Shipwright v0.13.0
      2. During reconcile loop, add a step to check for the presence of the removed cluster role and rolebinding.
      3. If the webhook cluster role and rolebinding are present, delete them.

      Dependencies

      <Describes what this story depends on. Dependent Stories and EPICs should be linked to the story.>

      • Upstream Shipwright v0.13.0 release

      Acceptance Criteria (Mandatory)

      <Describe edge cases to consider when implementing the story and defining tests>

      <Provides a required and minimum list of acceptance tests for this story. More is expected as the engineer implements this story>

      • Upstream operator deploys v0.13.0 in new clusters/installs.
      • Upstream operator can upgrade from v0.12.0 to v0.13.0
      • On upgrade, the webhook cluster role and rolebinding are deleted.

      INVEST Checklist

      Dependencies identified

      Blockers noted and expected delivery timelines set

      Design is implementable

      Acceptance criteria agreed upon

      Story estimated

      Legend

      Unknown

      Verified

      Unsatisfied

      Done Checklist

      • Code is completed, reviewed, documented and checked in
      • Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
      • Continuous Delivery pipeline(s) is able to proceed with new code included
      • Customer facing documentation, API docs etc. are produced/updated, reviewed and published
      • Acceptance criteria are met

              rh-ee-asatyam Ayush Satyam
              adkaplan@redhat.com Adam Kaplan
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: