Uploaded image for project: 'OpenShift Builds'
  1. OpenShift Builds
  2. BUILD-1185

Operator Does Not Requeue if ShipwrightBuild Reconcile Fails

XMLWordPrintable

    • False
    • Hide

      None

      Show
      None
    • False
    • Hide
      Before this update, there was an issue affecting the `OpenshiftBuild` controller and requeuing of reconciliation requests . If the {builds-operator} failed to reconcile the `ShipwrightBuild` or the `SharedResource` objects but the status update of the `OpenshiftBuild` controller succeeded, `OpenshiftBuild` controller was not requeued for reconciliation despite the previous failure. With this update, the issue is solved.
      Show
      Before this update, there was an issue affecting the `OpenshiftBuild` controller and requeuing of reconciliation requests . If the {builds-operator} failed to reconcile the `ShipwrightBuild` or the `SharedResource` objects but the status update of the `OpenshiftBuild` controller succeeded, `OpenshiftBuild` controller was not requeued for reconciliation despite the previous failure. With this update, the issue is solved.
    • Bug Fix
    • Builds Sprint #28, Builds Sprint #29, Builds Sprint #30, Builds Sprint #31
    • 4

      Description of problem:

      If the build operator fails to reconcile the ShipwrightBuild object for any reason, the operator logs a stack trace, but does not requeue itself if the status update to the OpenShiftBuild object succeeds

      Workaround: None

      Prerequisites (if any, like setup, operators/versions):

      Builds for OpenShift 1.1

      Steps to Reproduce

      Observed while attempting to add validation logic to the downstream operator unit tests.

       

      Actual results:

      Reconcile result does not requeue, even though there was an error in the reconcile process.

      Expected results:

      Operator requeues and tries to reconcile again.

      Reproducibility (Always/Intermittent/Only Once):

      Always

      Acceptance criteria: 

      TBD

      Definition of Done:

      Build Details:

      Additional info (Such as Logs, Screenshots, etc):

       

       *

              rh-ee-anborah Anchita Borah
              adkaplan@redhat.com Adam Kaplan
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: