Uploaded image for project: 'Application Server 7'
  1. Application Server 7
  2. AS7-1792

Fix the Logging description providers for the improved validation in jboss-as-subsystem-test

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Done
    • Icon: Major Major
    • 7.1.0.Beta1
    • None
    • Logging
    • None

      I added a test called LoggingSubsystemTestCase, which uses our subsystem testing framework which attempts to validate the description providers, this will be committed to upstream in the next few days.
      To make the tests pass I had to override AdditionalInitialization.getModelValidationConfiguration() and isValidateOperations() as follows:

               @Override
               protected ValidationConfiguration getModelValidationConfiguration() {
                   return null;
               }
      
      
                @Override
                protected boolean isValidateOperations() {
                    //TODO fix providers https://issues.jboss.org/browse/AS7-1789
                    return false;
                }
      
      

      Returning null basically turns off validation of the providers, and the isValidateOperations() override turns off validation of the contents of the actual operations. What I have added is a minimum of what is required for subsystem testing, the test framework allows you to do a lot of other stuff, see the jmx subsystem test for some examples.

      The wip lives at https://github.com/kabir/jboss-as/tree/subsystem-test-model-fixes

      The above is standard text as I'm going through and creating tests. The test has been @Ignored due to a further failure once validation 'passes' (i.e. the validation is not run due to the flags set)

              jperkins-rhn James Perkins
              kkhan1@redhat.com Kabir Khan
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

                Created:
                Updated:
                Resolved: