Uploaded image for project: 'Arquillian'
  1. Arquillian
  2. ARQ-49

Arquillian depends upon ShrinkWrap internals

XMLWordPrintable

      Caught that a few Arquillian classes are directly depending upon ShrinkWrap internals, for which we cannot provide guarantee of consistency between releases.

      [alr@localhost trunk]$ egrep 'shrinkwrap.impl' -R . |grep .java
      ./demo/src/test/java/com/acme/cdi/InjectionTestCase.java:import org.jboss.shrinkwrap.impl.base.asset.ByteArrayAsset;
      ./demo/src/test/java/com/acme/cdi/.svn/text-base/InjectionTestCase.java.svn-base:import org.jboss.shrinkwrap.impl.base.asset.ByteArrayAsset;
      ./impl-base/src/main/java/org/jboss/arquillian/impl/ArquillianDeploymentAppender.java: Package.getPackage("org.jboss.shrinkwrap.impl.base"),
      ./impl-base/src/main/java/org/jboss/arquillian/impl/.svn/text-base/ArquillianDeploymentAppender.java.svn-base: Package.getPackage("org.jboss.shrinkwrap.impl.base"),
      ./junit/src/main/java/org/jboss/arquillian/junit/JUnitTestRunner.java:import org.jboss.shrinkwrap.impl.base.Validate;
      ./junit/src/main/java/org/jboss/arquillian/junit/.svn/text-base/JUnitTestRunner.java.svn-base:import org.jboss.shrinkwrap.impl.base.Validate;
      ./testng/src/main/java/org/jboss/arquillian/testng/TestNGTestRunner.java:import org.jboss.shrinkwrap.impl.base.Validate;
      ./testng/src/main/java/org/jboss/arquillian/testng/.svn/text-base/TestNGTestRunner.java.svn-base:import org.jboss.shrinkwrap.impl.base.Validate;
      ./demo-testng/src/test/java/com/acme/cdi/InjectionTestCase.java:import org.jboss.shrinkwrap.impl.base.asset.ByteArrayAsset;
      ./demo-testng/src/test/java/com/acme/cdi/.svn/text-base/InjectionTestCase.java.svn-base:import org.jboss.shrinkwrap.impl.base.asset.ByteArrayAsset;

      Likely we'll want to evaluate these dependencies and instead move to API-only (for compile time, runtime requiring ShrinkWrap impls in "test" scope).

            aslak@redhat.com Aslak Knutsen
            arubinge@redhat.com Andrew Rubinger (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: