Uploaded image for project: 'Service Binding'
  1. Service Binding
  2. APPSVC-938

Unhandled panic with invalid elementType

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • Service Binding
    • AppSvc Sprint 207

      Owner: Architect:

      <Architect is responsible for completing this section to define the details of the story>

      Story (Required)

      As an OpenShift user, ServiceBindingOperator should not throw a panic when invalid annotations are set.

      Background (Required)

      A service could potentially have a completely invalid annotation (i.e. "service.binding/credentials: path='{.status.dbCredentials}',elementType=asdf").  Currently, SBO ignores the error thrown by these annotations and happily continues processing.

      SBO can potentially throw a panic when an annotation's elementType is invalid (i.e. setting elementType=asdf).  Instead, we should log an error and prevent the binding from occurring.

      In Scope

      Changes to SBO to remove this panic and tests to ensure it doesn't return.

      Approach(Required)

      Find how this panic can be triggered and write tests verifying this behavior, then ensure these tests pass when the panic is removed.

       

      INVEST Checklist

      Dependencies identified
      Blockers noted and expected delivery timelines set
      Design is implementable
      Acceptance criteria agreed upon
      Story estimated

      Legend

      Unknown
      Verified
      Unsatisfied

            ansadler@redhat.com Andy Sadler
            ansadler@redhat.com Andy Sadler
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: