Uploaded image for project: 'OpenShift API Server'
  1. OpenShift API Server
  2. API-1492

openapi-gen output isn't deterministic

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • None
    • openshift-apiserver
    • False
    • None
    • False
    • Impediment

      Noticed that openshift-apiserver's verify job sometimes fails because hack/update-generated-openapi.sh sometimes produces this diff:

      diff --git a/pkg/openapi/zz_generated.openapi.go b/pkg/openapi/zz_generated.openapi.go
      index e6ba4c015..dbe226362 100644
      --- a/pkg/openapi/zz_generated.openapi.go
      +++ b/pkg/openapi/zz_generated.openapi.go
      @@ -61886,11 +61886,11 @@ func schema_k8sio_api_core_v1_LimitRangeItem(ref common.ReferenceCallback) commo
                                      Properties: map[string]spec.Schema{
                                              "type": {
                                                      SchemaProps: spec.SchemaProps{
      -                                                       Description: "Type of resource that this limit applies to.\n\nPossible enum values:\n - `\"Container\"` Limit that applies to all containers in a namespace\n - `\"PersistentVolumeClaim\"` Limit that applies to all persistent volume claims in a namespace\n - `\"Pod\"` Limit that applies to all pods in a namespace",
      +                                                       Description: "Type of resource that this limit applies to.\n\nPossible enum values:\n - `\"Container\"` Limit that applies to all containers in a namespace\n - `\"PersistentVolumeClaim\"` Limit that applies to all persistent volume claims in a namespace\n - `\"Pod\"` Limit that applies to all pods in a namespace\n - `\"openshift.io/Image\"` Limit that applies to images. Used with a max[\"storage\"] LimitRangeItem to set the maximum size of an image.\n - `\"openshift.io/ImageStream\"` Limit that applies to image streams. Used with a max[resource] LimitRangeItem to set the maximum number of resource. Where the resource is one of \"openshift.io/images\" and \"openshift.io/image-tags\".",
                                                              Default:     "",
                                                              Type:        []string{"string"},
                                                              Format:      "",
      -                                                       Enum:        []interface{}{"Container", "PersistentVolumeClaim", "Pod"}},
      +                                                       Enum:        []interface{}{"Container", "PersistentVolumeClaim", "Pod", "openshift.io/Image", "openshift.io/ImageStream"}},
                                              },
                                              "max": {
                                                      SchemaProps: spec.SchemaProps{ 

              bluddy Ben Luddy
              bluddy Ben Luddy
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: