Definition of Done:

• Implement the RFE https://issues.redhat.com/browse/AAPRFE-1508
• Code completed to meet acceptance criteria based on architecture documents/requirements.
• Pull Request reviewed and approved by peers.
• Tests are written and do not "break the build" (all tests pass CI/CD). Type of tests (unit/ integration) dependent on need and content. 
  • Run tests locally with downstream EE  if required in following cases:
    • The Downstream CI fails for the PR ( setup local EE to debug the issue)
    • PR change specifically requires tests to be ran against a local EE
    • A passing downstream Jenkins CI pipeline run is required if any of these criterias are met:

• • • • The PR touches code in ansible.utils or ansible.netcommon.
      • The PR has integration test changes. As such, any PR that adds a new plugin would require this.
      • The PR touches a plugin that is dependent on a third party library (e.g., xmltodict, pyats, etc.).
      • The PR resolves a customer ticket (bug/feature).
  • Changelog written, except for trivial changes such as test updates, GHA workflow updates, linter changes, etc.
• Add an update in https://issues.redhat.com/browse/AAPRFE-1508 when the work is merged and closed.