Part of #169578
-
- Summary
Spring cleaning time! Removing the `skip_code_recursive_on_recompile_limit_hit` config variable that's been sitting around with a "deprecated: does not do anything" for some time now.
-
- deprecated: does not do anything
Here's where it gets interesting: the config was marked as deprecated and "does not do anything"... but the tests had other ideas. Turns out that the justknobs did not make it clear-cut how active this is.
This PR removes both the deprecated config AND the justknobs check, while keeping everything working exactly as it does today (in theory)
-
- Changes
*torch/_dynamo/config.py:*
- Removed `skip_code_recursive_on_recompile_limit_hit` config variable
- Removed `skip_code_recursive_on_cache_limit_hit` alias
*torch/_dynamo/convert_frame.py:*
- Removed unused `justknobs_check` import
- Deleted the justknobs conditional that was doing the actual work
- Changed the control flow to directly raise `RecompileLimitExceeded`
These last two points could use verification of correctness.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo