Uploaded image for project: 'AI Platform Core Components'
  1. AI Platform Core Components
  2. AIPCC-7857

[dynamo] Remove deprecated skip_code_recursive_on_recompile_limit_hit config

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • PyTorch
    • False
    • Hide

      None

      Show
      None
    • False
    • PyTorch Sprint 21, PyTorch Sprint 22, PyTorch Sprint 23, PyTorch Sprint 24, PyTorch Sprint 25, PyTorch Sprint 26

      Part of #169578

        1. Summary

      Spring cleaning time! Removing the `skip_code_recursive_on_recompile_limit_hit` config variable that's been sitting around with a "deprecated: does not do anything" for some time now.

        1. deprecated: does not do anything

      Here's where it gets interesting: the config was marked as deprecated and "does not do anything"... but the tests had other ideas. Turns out that the justknobs did not make it clear-cut how active this is.

      This PR removes both the deprecated config AND the justknobs check, while keeping everything working exactly as it does today (in theory)

        1. Changes

      *torch/_dynamo/config.py:*

      • Removed `skip_code_recursive_on_recompile_limit_hit` config variable
      • Removed `skip_code_recursive_on_cache_limit_hit` alias

      *torch/_dynamo/convert_frame.py:*

      • Removed unused `justknobs_check` import
      • Deleted the justknobs conditional that was doing the actual work
      • Changed the control flow to directly raise `RecompileLimitExceeded`

      These last two points could use verification of correctness.
      cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo

      GitHub PR: https://github.com/pytorch/pytorch/pull/169593

              rh-ee-hgudmund Hinrik Gudmundsson
              rh-ee-hgudmund Hinrik Gudmundsson
              PyTorch Compile
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: