Uploaded image for project: 'Agroal'
  1. Agroal
  2. AG-220

Do not register RecoveryRegistry when not applicable in Spring Configuration

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Done
    • Major
    • 2.3
    • None
    • narayana, pool, spring
    • None
    • False
    • None
    • False

    Description

      With AG-206 support for LRCO and non-XADataSources was added, but it seems like a non-XADataSource is unnecessarily registered with XARecoveryRegistry now. While this does not actually create a problem it does unnecesserily log warnings when trying to get a RecoveryConnection (from ConnectionFactory#getRecoveryConnection): "Recovery connections are only available for XADataSource)

      It seems like when a DataSource is being configured, if it is not actually an XADataSource (for instance a "connectable" DataSource), that it also should not be registered in the RecoveryRegistry.

      Attachments

        Issue Links

          is caused by

          Enhancement - An enhancement to or refactoring of existing functionality that is not configurable by an end user (typically a change made by an internal team that affects users) AG-206 [spring] Improve DataSourceConfiguration

          • Minor - To be worked after urgent, high, and medium priorities are resolved. This term is chosen when the severity of the issue is low, or the complexity or effort to correct it may be higher, relatively speaking. For low priority issues, known workarounds exist or are not needed due to the trivial effort needed to address the issue.
          • Closed

          Activity

            People

              lbarreiro-1 Luis Barreiro
              kimdlanor Ronald Mik
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: