Uploaded image for project: 'AppFormer'
  1. AppFormer
  2. AF-604

[Perspective Editor] cancel button doesn't work properly when adding components above/below other components

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Minor Minor
    • 1.5.0.Final
    • None
    • None
    • 2017 Week 36-37, 2017 Week 38-39, 2017 Week 40-41-42, 2017 Week 43-44, 2017 Week 45-46, 2017 Week 47-48, 2017 Week 49-50, 2017 Week 51-52
    • Hide

      See steps in video. Here's textual description:
      1. Create new perspective
      2. Drag a HTML component to layout (can also be reproduced with other components)
      3. Repeat the following step - notice that after each step one more "layer" is added even though the button Cancel is clicked

      • drag new HTML component ABOVE the existing HTML component and click cancel

      Expected result: After Cancel is clicked, the layout should return to a state it was in before the component was dragged
      Actual result: After Cancel is clicked, some kind of "new layer" border is created as if something was added to the layout, but no content is shown

      Show
      See steps in video. Here's textual description: 1. Create new perspective 2. Drag a HTML component to layout (can also be reproduced with other components) 3. Repeat the following step - notice that after each step one more "layer" is added even though the button Cancel is clicked drag new HTML component ABOVE the existing HTML component and click cancel Expected result: After Cancel is clicked, the layout should return to a state it was in before the component was dragged Actual result: After Cancel is clicked, some kind of "new layer" border is created as if something was added to the layout, but no content is shown
    • Hide
      Already fixed on this change:
      https://github.com/kiegroup/appformer/commit/ffd07ba15550659921d3a2cb55d9520e39d6a5de#diff-5f7d7d5607967a66d5196ce8a6e6c257
      Show
      Already fixed on this change: https://github.com/kiegroup/appformer/commit/ffd07ba15550659921d3a2cb55d9520e39d6a5de#diff-5f7d7d5607967a66d5196ce8a6e6c257
    • NEW
    • NEW

      Cancel button in the modal for adding draggable component's in perspective editor doesn't cancel component addition properly - in some cases a piece of layout without content ("extra border") is added even though cancel is clicked. See example in the video attached.

      I suspect this might have something to do with cancel button functionality implementation in the following PR:
      https://github.com/AppFormer/uberfire/commit/bbdd60ec9a019a9a373c5cced838651a30e584e6

        1. stepsToReproduce.webm
          1.25 MB

            rh-ee-pefernan Pere Fernandez Perez
            jhrcek Jan Hrcek (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: