Uploaded image for project: 'AppFormer'
  1. AppFormer
  2. AF-2642

Enable business central to have a default branch different than master

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • 7.43.1.Final
    • General workbench, Library
    • None
    • Documentation (Ref Guide, User Guide, etc.)
    • Undefined
    • NEW
    • NEW

      There is an initiative to rename the default master branch to something like main. More details here and here.

      Considering this scenario, our code is not fully prepared for it since there many places where master is hardcoded.

      Features like Import Project wouldn't work and some workflows would break.

      For example, if you rename the master branch and push back to Business Central, then users would be able to delete this branch.

      Also, some exceptions would be thrown.

       

      Currently, we also have a disabled config on the global settings for the default branch, which is master.

      This has to be considered when addressing this task.

       

       

      Thus, the goal is to refactor all hardcoded references, possibly centralizing this property, and make Business Central prepared for scenarios where the default branch is not master.

       

      Places where master is somehow hardcoded (tests are not considered):

      appfomer
      uberfire-extensions/uberfire-commons-editor/uberfire-commons-editor-backend/src/main/java/org/uberfire/ext/editor/commons/backend/version/VersionRecordServiceImpl.java 
      
      uberfire-extensions/uberfire-commons-editor/uberfire-commons-editor-backend/src/main/java/org/uberfire/ext/editor/commons/backend/version/VersionUtil.java 
      
      uberfire-extensions/uberfire-commons-editor/uberfire-commons-editor-client/src/main/java/org/uberfire/ext/editor/commons/client/menu/common/DefaultCurrentBranch.java 
      
      uberfire-nio2-backport/uberfire-nio2-impls/uberfire-nio2-jgit/src/main/java/org/uberfire/java/nio/fs/jgit/JGitPathImpl.java
      
      uberfire-nio2-backport/uberfire-nio2-impls/uberfire-nio2-jgit/src/main/java/org/uberfire/java/nio/fs/jgit/util/GitImpl.java 
      
      uberfire-nio2-backport/uberfire-nio2-impls/uberfire-nio2-jgit/src/main/java/org/uberfire/java/nio/fs/jgit/JGitFileSystemProvider.java 
      
      uberfire-nio2-backport/uberfire-nio2-model/src/main/java/org/uberfire/java/nio/base/GeneralPathImpl.java 
      
      uberfire-project/uberfire-project-backend/src/main/java/org/guvnor/common/services/project/backend/server/WorkspaceProjectMigrationServiceImpl.java 
      
      uberfire-project/uberfire-project-backend/src/main/java/org/guvnor/common/services/project/backend/server/WorkspaceProjectServiceImpl.java 
      
      uberfire-project/uberfire-project-client/src/main/java/org/guvnor/common/services/project/client/security/ProjectController.java 
      
      uberfire-structure/uberfire-structure-api/src/main/java/org/guvnor/structure/repositories/Repository.java 
      
      uberfire-structure/uberfire-structure-api/src/main/java/org/guvnor/structure/repositories/impl/git/GitRepository.java 
      
      uberfire-structure/uberfire-structure-backend/src/main/java/org/guvnor/structure/backend/repositories/ConfiguredRepositoriesImpl.java 
      
      uberfire-structure/uberfire-structure-backend/src/main/java/org/guvnor/structure/backend/config/ConfigurationServiceImpl.java
      kie-wb-common
      kie-wb-common-ala/kie-wb-common-ala-source-git/src/main/java/org/guvnor/ala/source/git/GitRepository.java
      
      kie-wb-common-ala/kie-wb-common-ala-source-git/src/main/java/org/guvnor/ala/source/git/executor/GitConfigExecutor.java
      
      kie-wb-common-screens/kie-wb-common-library/kie-wb-common-library-api/src/main/java/org/kie/workbench/common/screens/library/api/preferences/LibraryPreferences.java
      
      kie-wb-common-screens/kie-wb-common-library/kie-wb-common-library-client/src/main/java/org/kie/workbench/common/screens/library/client/settings/sections/branchmanagement/RoleItemPresenter.java
      
      kie-wb-common-screens/kie-wb-common-library/kie-wb-common-library-client/src/main/java/org/kie/workbench/common/screens/library/client/widgets/example/branchselector/BranchSelectorPopUpView.java
      
      kie-wb-common-screens/kie-wb-common-library/kie-wb-common-library-client/src/main/java/org/kie/workbench/common/screens/library/client/widgets/example/branchselector/BranchSelectorPopUpPresenter.java
      
      kie-wb-common-screens/kie-wb-common-archetype-mgmt/kie-wb-common-archetype-mgmt-backend/src/main/java/org/kie/workbench/common/screens/archetype/mgmt/backend/service/ArchetypeServiceImpl.java
      
      kie-wb-common-screens/kie-wb-common-examples-screen/kie-wb-common-examples-screen-backend/src/main/java/org/kie/workbench/common/screens/examples/backend/server/BaseProjectImportService.java
      
      kie-wb-common-services/kie-wb-common-refactoring/kie-wb-common-refactoring-backend/src/main/java/org/kie/workbench/common/services/refactoring/backend/server/query/assetUsages/AssetsUsageServiceImpl.java
      jbpm-designer
      jbpm-designer-backend/src/main/java/org/jbpm/designer/repository/vfs/RepositoryDescriptorProvider.java
      jbpm-wb
      jbpm-wb-integration/jbpm-wb-integration-backend/src/main/java/org/jbpm/workbench/wi/backend/server/workitem/WorkbenchRepositoryEventListener.java
      jbpm-work-items
      github-workitem/src/main/java/org/jbpm/process/workitem/github/RepositoryInfo.java

              eignatow Eder Ignatowicz
              gcaponet Guilherme Caponetto
              Votes:
              6 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated: