Description of problem:

When a user attempts to upgrade ACM, if there are multiple catalogsources that contain a targeted channel for upgrade, the operator will throw an error in reference to not finding a suitable catalogsource:

2023-10-24T16:24:59.694Z INFO Failed to find a suitable catalogsource. {"controller": "multiclusterhub", "controllerGroup": "operator.open-cluster-management.io", "controllerKind": "MultiClusterHub", "MultiClusterHub": {"name":"multiclusterhub","namespace":"ocm"}, "namespace": "ocm", "name": "multiclusterhub", "reconcileID": "2e675770-1e59-4ad6-b963-e211c5539b96", "error": "Found more than one multicluster-engine catalogSource with expected channel stable-2.3"} 

The error is occurring because there are multiple catalogsources with the same package and channel available to be upgraded from. When this issue arises, MCH will continue to report as running; however, we should elevate that error message to the MCH and show that the operator "Found more than one multicluster-engine catalogSource with expected channel stable-2.3"}"

Version-Release number of selected component (if applicable):

ACM 2.7+

How reproducible:

When there are multiple catalogsources with the same MCE package and channel.

Steps to Reproduce:

1. Deploy a custom MCH catalogsource to setup MCH.
2. Deploy a custom MCE catalogsource to setup MCE.
3. When ACM and MCE are fully deployed onto the cluster, attempt to upgrade the cluster environment.
4. The user should see an error within the multiclusterhub-operator logs that show that there are multiple catalogsources found with the expected channel.

Actual results:

MCH operator throws an error, but continues with rolling out the next version MCH operands.

Expected results:

MCH should throw an error and show that there are multiple catalogsources before proceeding with any upgrade.

Additional info: