-
Story
-
Resolution: Can't Do
-
Critical
-
None
Value Statement
It is important to run canary tests to verify the built image.
Definition of Done for Engineering Story Owner (Checklist)
- Provide test to setup global hub environment based on 2 ACM clusters(refer to https://github.com/stolostron/multicluster-observability-operator/blob/main/tests/pkg/tests/observability_install_test.go)
-
- Install global hub operator in one ACM hub cluster using built image
- Create mcgh to initiate the global hub
- Import the other ACM hub as local local
- Build e2e tests in a docker image
- have a dockerfile to build e2e into a docker image named global-hub-e2e (refer to: https://github.com/stolostron/multicluster-observability-operator/blob/main/tests/Dockerfile)
- run the docker image with proper parameters to start the e2e( for instance: https://github.com/stolostron/canary-scripts/blob/c9b92620b33ebfab0ae836e698870b442935284e/squad-tests/observability/run_test.sh#L63-L70). in the way, the canary does not need to fork the global hub to run the test.
- expose the test results (https://github.com/stolostron/canary-scripts/blob/c9b92620b33ebfab0ae836e698870b442935284e/squad-tests/observability/run_test.sh#L66)
- Write a script in canary-script to enable the tests (https://github.com/stolostron/canary-scripts/blob/2.7-integration/squad-tests/observability/run_test.sh)
Development Complete
- The code is complete.
- Functionality is working.
- Any required downstream Docker file changes are made.
Tests Automated
- [ ] Unit/function tests have been automated and incorporated into the
build. - [ ] 100% automated unit/function test coverage for new or changed APIs.
Secure Design
- [ ] Security has been assessed and incorporated into your threat model.
Multidisciplinary Teams Readiness
- [ ] Create an informative documentation issue using the [Customer
Portal_doc_issue template](
https://github.com/stolostron/backlog/issues/new?assignees=&labels=squad%3Adoc&template=doc_issue.md&title=),
and ensure doc acceptance criteria is met. Link the development issue to
the doc issue. - [ ] Provide input to the QE team, and ensure QE acceptance criteria
(established between story owner and QE focal) are met.
Support Readiness
- [ ] The must-gather script has been updated.