Uploaded image for project: 'Red Hat Advanced Cluster Management'
  1. Red Hat Advanced Cluster Management
  2. ACM-4309

Configuration Policy Controller can panic if a policy's annotations are null

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • ACM 2.8.0
    • ACM 2.6.5, ACM 2.8.0, ACM 2.7.3
    • GRC
    • None
    • 2
    • False
    • None
    • False
    • GRC Sprint 2023-05
    • Important
    • No

      Sometimes a configurationpolicy specifying `annotations: null` inside the object templates will cause the configuration policy controller to crash. The panic log is like:

       

      panic: interface conversion: interface {} is nil, not map[string]interface {}{}1718goroutine 1099 [running]:19open-cluster-management.io/config-policy-controller/controllers.fmtMetadataForCompare(0x16e43c0?, 0xc000e20240?)20/go/src/github.com/stolostron/config-policy-controller/controllers/configurationpolicy_utils.go:386 +0x57821open-cluster-management.io/config-policy-controller/controllers.handleSingleKey({0xc0000428e0, 0x8}, {0x8?}, 0xc0003580b8, {0xc0007d1f08, 0x8})22/go/src/github.com/stolostron/config-policy-controller/controllers/configurationpolicy_controller.go:2434 +0x79f23open-cluster-management.io/config-policy-controller/controllers.(*ConfigurationPolicyReconciler).checkAndUpdateResource(0xc0001be8c0, {0xc000626600, {{0xc0001b1b18, 0x14}, {0xc000bf7930, 0x2}, {0xc0009a4c30, 0xe, 0xc0003580b8, {0xc0004cb3cc, ...}, ...}, ...){}}}24/go/src/github.com/stolostron/config-policy-controller/controllers/configurationpolicy_controller.go:2535 +0x53025open-cluster-management.io/config-policy-controller/controllers.(*ConfigurationPolicyReconciler).handleSingleObj(0xc0001be8c0, {0xc000626600, {{0xc0001b1b18, 0x14}, {0xc000bf7930, 0x2}, {0xc0009a4c30, 0xe, 0xc0003580b8, {0xc0004cb3cc, ...}, ...}, ...){}}}26/go/src/github.com/stolostron/config-policy-controller/controllers/configurationpolicy_controller.go:1657 +0xbb9{{{}27open-cluster-management.io/config-policy-controller/controllers.(*ConfigurationPolicyReconciler).handleObjects(0xc0001be8c0, 0xc00032a370, {0xc0004cb3f0, 0x8}, {

      {0xc0004cb3b0, 0xd}

      , {0xc0004cb3cc, 0x3}, {0xc0004cb3f0, 0x8}, ...}, ...){}}}28/go/src/github.com/stolostron/config-policy-controller/controllers/configurationpolicy_controller.go:1477 +0x102529open-cluster-management.io/config-policy-controller/controllers.(*ConfigurationPolicyReconciler).handleObjectTemplates(_, {{{0x158d5ff, 0x13}, {0xc000408ba0, 0x24, {

      {0xc0005b8f18, 0x16}

      , {0x0, 0x0}, {0xc0007d1ef0, ...}, ...}, ...}){}}}30/go/src/github.com/stolostron/config-policy-controller/controllers/configurationpolicy_controller.go:1074 +0x2bee31open-cluster-management.io/config-policy-controller/controllers.(*ConfigurationPolicyReconciler).handlePolicyWorker(0xc10560?, 0xc000e76f30?, 0xc00056dfb8?)32/go/src/github.com/stolostron/config-policy-controller/controllers/configurationpolicy_controller.go:282 +0x1ec33created by open-cluster-management.io/config-policy-controller/controllers.(*ConfigurationPolicyReconciler).PeriodicallyExecConfigPolicies34/go/src/github.com/stolostron/config-policy-controller/controllers/configurationpolicy_controller.go:232 +0x71f

            jkulikau@redhat.com Justin Kulikauskas
            jkulikau@redhat.com Justin Kulikauskas
            Derek Ho Derek Ho
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: