Value Statement

In order to simplify the creation of SLI/SLO for SD, the following enhancements on foundation metrics are required:

1. Currently the acm_managed_cluster_addon_status_condition metrics are only generated for work-manager. Actually it is required by other add-ons, like hypershift/policy add-ons, as well.

2. Report continuous data of acm_managed_cluster_status_condition / acm_managed_cluster_addon_status_condition / acm_manifestwork_status_condition metrics for all possible status values of a certain condition. For example, currently only one metric item is reported for a ManagedCluster that has a condition ManagedClusterConditionAvailable with status True:
acm_managed_cluster_status_condition{managed_cluster_name="local-cluster",condition="ManagedClusterConditionAvailable",status="true"} 1

while usually 3 data items are desired and 2 of them have value 0, which makes it easy to create SLO based on this condition.
acm_managed_cluster_status_condition{managed_cluster_name="local-cluster",condition="ManagedClusterConditionAvailable",status="true"} 1
acm_managed_cluster_status_condition{managed_cluster_name="local-cluster",condition="ManagedClusterConditionAvailable",status="false"} 0
acm_managed_cluster_status_condition{managed_cluster_name="local-cluster",condition="ManagedClusterConditionAvailable",status="unknown"} 0{}

Since some of the conditions ((see a list below)) only support two status values: true and false, there will be no metric generated for status unknown.

• managed cluster
  • HubAcceptedManagedCluster
  • HubDeniedManagedCluster
  • ManagedClusterJoined
  • ManagedClusterImportSucceeded
  • ExternalManagedKubeconfigCreatedSucceeded
• add-on
  • RegistrationApplied
  • ManifestApplied
  • ClusterCertificateRotated
  • UnsupportedConfiguration

Definition of Done for Engineering Story Owner (Checklist)

• ...

Development Complete

• The code is complete.
• Functionality is working.
• Any required downstream Docker file changes are made.

Tests Automated

• [ ] Unit/function tests have been automated and incorporated into the
  build.
• [ ] 100% automated unit/function test coverage for new or changed APIs.

Secure Design

• [ ] Security has been assessed and incorporated into your threat model.

Multidisciplinary Teams Readiness

• [ ] Create an informative documentation issue using the [Customer
  Portal_doc_issue template](
  https://github.com/stolostron/backlog/issues/new?assignees=&labels=squad%3Adoc&template=doc_issue.md&title=),
  and ensure doc acceptance criteria is met. Link the development issue to
  the doc issue.
• [ ] Provide input to the QE team, and ensure QE acceptance criteria
  (established between story owner and QE focal) are met.

Support Readiness

• [ ] The must-gather script has been updated.