Epic Goal

The configuration of the policy components on managed clusters (for example, options exposed in command-line flags) should be able to be managed via AddOnDeploymentConfig resources.

Why is this important?

AddOnDeploymentConfig is a common resource that ACM users should be able to utilize to configure components. However, there are currently many options in our controllers which can not be managed with that resource. If we can improve that experience, it may encourage users to become comfortable with these resources, which will help unify the experience of configuring any ACM components in the future.

Scenarios

For one specific example, take the ability to enable/disable OperatorPolicy. There is a command line flag in the config-policy-controller (1). That flag can currently be configured in the Helm Chart (2). However, that value can not currently be managed directly with an AddOnDeploymentConfig with its customizedVariables field. Instead, we look for a specific annotation on the ManagedClusterAddOn (3), which we do not document particularly well. 

There are additional options in many of our controllers that aren't in the helm chart at all, and it would be nice to be able to configure all of them in a consistent way.

(1) https://github.com/open-cluster-management-io/config-policy-controller/blob/main/main.go#L901

(2) https://github.com/open-cluster-management-io/governance-policy-addon-controller/blob/main/pkg/addon/configpolicy/manifests/managedclusterchart/values.yaml#L20 

(3) https://github.com/open-cluster-management-io/governance-policy-addon-controller/blob/main/pkg/addon/configpolicy/agent_addon.go#L206 

Acceptance Criteria

...

Dependencies (internal and external)

1. ...

Previous Work (Optional):

1. ...

Open questions:

1. …

Done Checklist

• CI - CI is running, tests are automated and merged.
• Release Enablement <link to Feature Enablement Presentation>
• DEV - Upstream code and tests merged: <link to meaningful PR or GitHub
  Issue>
• DEV - Upstream documentation merged: <link to meaningful PR or GitHub
  Issue>
• DEV - Downstream build attached to advisory: <link to errata>
• QE - Test plans in Polarion: <link or reference to Polarion>
• QE - Automated tests merged: <link or reference to automated tests>
• DOC - Doc issue opened with a completed template. Separate doc issue
  opened for any deprecation, removal, or any current known
  issue/troubleshooting removal from the doc, if applicable.
• Considerations were made for Extended Update Support (EUS)