Uploaded image for project: 'Red Hat Advanced Cluster Management'
  1. Red Hat Advanced Cluster Management
  2. ACM-26957

MulticlusterRoleAssignment - Move cluster tracker from annotations to status

XMLWordPrintable

    • Product / Portfolio Work
    • False
    • Hide

      None

      Show
      None
    • False
    • Hide

      Provide the required acceptance criteria using this template.

      • ...
      Show
      Provide the required acceptance criteria using this template. ...
    • Not Selected
    • Important
    • None

      Value Statement

      For 2.15, MulticlusterRoleAssignment controller logic saves this annotation in MRAs:

      mjs@41f7068020ed:/UbuntuSync$ oc get multiclusterroleassignment -A -oyaml
      apiVersion: v1
      items:
      - apiVersion: rbac.open-cluster-management.io/v1alpha1
        kind: MulticlusterRoleAssignment
        metadata:
          annotations:
            clusters.rbac.open-cluster-management.io: local-cluster;sno-2-lpwmd;sno-2-xj8n6
      ... 

      Putting clusters in annotations is bad kubernetes practice. This should get moved to .status.

      Definition of Done for Engineering Story Owner (Checklist)

      • "All clusters" tracker is moved from annotations to status
      • Tests are updated accordingly

      Development Complete

      • The code is complete.
      • Functionality is working.
      • Any required downstream Docker file changes are made.

      Tests Automated

      • [ ] Unit/function tests have been automated and incorporated into the
        build.
      • [ ] 100% automated unit/function test coverage for new or changed APIs.

      Secure Design

      • [ ] Security has been assessed and incorporated into your threat model.

      Multidisciplinary Teams Readiness

      • [ ] Create an informative documentation issue using the Customer

      Portal Doc template that you can access from [The Playbook](

      https://docs.google.com/document/d/1YTqpZRH54Bnn4WJ2nZmjaCoiRtqmrc2w6DdQxe_yLZ8/edit#heading=h.9fvyr2rdriby),

      and ensure doc acceptance criteria is met.

      • Call out this sentence as it's own action:
      • [ ] Link the development issue to the doc issue.

      Support Readiness

      • [ ] The must-gather script has been updated.

              Unassigned Unassigned
              rh-ee-mshort Matthew Short
              Atif Shafi Atif Shafi
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: