Uploaded image for project: 'Red Hat Advanced Cluster Management'
  1. Red Hat Advanced Cluster Management
  2. ACM-23760

SiteConfig use of deprecated webhook code blocks inclusion of HCP API

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Not a Bug
    • Icon: Normal Normal
    • None
    • None
    • SiteConfig Operator
    • None
    • Quality / Stability / Reliability
    • False
    • Hide

      None

      Show
      None
    • False
    • Moderate
    • None

      Description of problem:

      Per [kubernetes-sigs/kubebuilder#3721, the webhook.Validator interface was deprecated, and has been removed in recent release of the API.

      This causes compilation errors after bumping Go to 1.24 and refreshing the vendor tree.

      Version-Release number of selected component (if applicable):

      Github main branch

      How reproducible:

      Always

      Steps to Reproduce:

      1. Add a v0.0.0 reference to openshift/hypershift/api to go.mod
      2. go mod vendor
      3. go mod tidy
      4. make docker-build

      Actual results:

      08:06 $ CONTAINER_TOOL=podman make docker-build
      Running unit tests
      go test -v ./...
      # github.com/openshift/assisted-service/api/v1beta1
      vendor/github.com/openshift/assisted-service/api/v1beta1/agent_webhook.go:43:15: undefined: webhook.Validator
      vendor/github.com/openshift/assisted-service/api/v1beta1/agentclassification_webhook.go:50:15: undefined: webhook.Validator
      vendor/github.com/openshift/assisted-service/api/v1beta1/infraenv_webhook.go:41:15: undefined: webhook.Validator

      Expected results:

      Clean compile and updated vendor tree

      Additional info:

      https://github.com/sakhoury/siteconfig/issues/29 Same as an issue in gh

      https://github.com/stolostron/siteconfig/pull/353 PR where this is blocking

      https://issues.redhat.com/browse/CNF-18296 Issue blocked by this

       

              sakhoury@redhat.com Sharat Akhoury
              rh_cwilkers Chandler Wilkerson
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: