Uploaded image for project: 'Red Hat Advanced Cluster Management'
  1. Red Hat Advanced Cluster Management
  2. ACM-20648

[MCH] As an Installer Dev, I want to refactor a generic solution to preserve all -preview components during upgrade

XMLWordPrintable

    • Quality / Stability / Reliability
    • 2
    • False
    • Hide

      None

      Show
      None
    • False
    • Hide

      Provide the required acceptance criteria using this template.

      • ...
      Show
      Provide the required acceptance criteria using this template. ...
    • None

      Value Statement

      When upgrading from a version of ACM that has -preview components to one where that component has been GA'd, the upgrade process disables the -preview version, unless the code has been manually configured to enable the GA version. This solution should be done generically to reduce repeated code and avoid forgetting to manually enable this when GA-ing the component.

       

      The setDefaults() function in multiclusterhub_controller.go is where the components are being enabled/pruned during installation and upgrade. This is likely the best place to refactor.

      Definition of Done for Engineering Story Owner (Checklist)

      • [x] A generic solution function is written
      • [x] Previous enable/prune steps are refactored to use the generic solution

      Development Complete

      • The code is complete.
      • Functionality is working.
      • Any required downstream Docker file changes are made.

      Tests Automated

      • [ ] Unit/function tests have been automated and incorporated into the
        build.
      • [ ] 100% automated unit/function test coverage for new or changed APIs.

      Secure Design

      • [ ] Security has been assessed and incorporated into your threat model.

      Multidisciplinary Teams Readiness

      • [ ] Create an informative documentation issue using the Customer

      Portal Doc template that you can access from [The Playbook](

      https://docs.google.com/document/d/1YTqpZRH54Bnn4WJ2nZmjaCoiRtqmrc2w6DdQxe_yLZ8/edit#heading=h.9fvyr2rdriby),

      and ensure doc acceptance criteria is met.

      • Call out this sentence as it's own action:
      • [ ] Link the development issue to the doc issue.

      Support Readiness

      • [ ] The must-gather script has been updated.

              dbennett@redhat.com Disaiah Bennett
              rh-ee-ngraham Nathaniel Graham
              Matthew Smigielski Matthew Smigielski
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: