-
Task
-
Resolution: Done
-
Normal
-
None
-
None
-
Product / Portfolio Work
-
5
-
False
-
-
False
-
-
-
ACM Console Train 30 - 1
-
Low
-
None
Value
Moving our form wizard library into the main repository will simplify testing out changes in the library that are made for ACM. It will reduce the number of PRs needed to get a change in the library into ACM. It will also eliminate the need to publish packages to npmjs.com and to maintain version branches for maintenance as tracked here.
Approach
We could copy the react-form-wizard code into our main repository similar to what was done for ui-components, or we could set it up as a workspace, so that it remains somewhat separate, but still within the same repository. The advantages of setting it up as workspace would be:
- No need to update imports in existing code
- Provides a logical place to put demo code
- More easily reversible should we decide to start publishing the package again
- Can have its own dependencies, so that upgrading PF, for example, could be handled separately for the library code
- Most existing npm scripts can be used as-is
Some disadvantages to this approach: - Need to build the workspace after any change in order for the main frontend package to pick up the updated code
Acceptance Criteria
- react-form-wizard code is sourced from the stolostron/console repository, eliminating need to install the package from npmjs.com
- Code is updated to match indentation and linting rules in the rest of the console
- Any testing (Cypress) that runs as part of PR process is preserved in console
- Maybe: Preserve Git history while doing so
Out of Scope
- Unit test coverage. TBD if we set up this code to be subject to coverage rules or not. The existing Cypress tests are not generating coverage.
- is depended on by
-
ACM-13499 Remove deprecated PF5 components in patternfly-labs/react-form-wizard
-
- Closed
-