Uploaded image for project: 'Red Hat Advanced Cluster Management'
  1. Red Hat Advanced Cluster Management
  2. ACM-20373

As an MCH developer, I want to re-factor files which have exceeded code quality allowable length

XMLWordPrintable

    • Quality / Stability / Reliability
    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • Hide

      Provide the required acceptance criteria using this template.

      • ...
      Show
      Provide the required acceptance criteria using this template. ...
    • Green
    • Installer Sprint 2025-60, Installer Sprint 2025-68
    • Low
    • None

      Value Statement

      Some of our files in the MCH repo, particularly multiclusterhub_controller.go have reached the maximum allowable number of lines as permitted by sonar cloud's code quality and maintainability standards. We need to re-factor this file and check others to allow further development

      Definition of Done for Engineering Story Owner (Checklist)

      • All files within the MCH repo fall well below the maximum allowable 1500 lines of code to allow for future development

      Development Complete

      • The code is complete.
      • Functionality is working.
      • Any required downstream Docker file changes are made.

      Tests Automated

      • [ ] Unit/function tests have been automated and incorporated into the
        build.
      • [ ] 100% automated unit/function test coverage for new or changed APIs.

      Secure Design

      • [ ] Security has been assessed and incorporated into your threat model.

      Multidisciplinary Teams Readiness

      • [ ] Create an informative documentation issue using the Customer

      Portal Doc template that you can access from [The Playbook](

      https://docs.google.com/document/d/1YTqpZRH54Bnn4WJ2nZmjaCoiRtqmrc2w6DdQxe_yLZ8/edit#heading=h.9fvyr2rdriby),

      and ensure doc acceptance criteria is met.

      • Call out this sentence as it's own action:
      • [ ] Link the development issue to the doc issue.

      Support Readiness

      • [ ] The must-gather script has been updated.

      -------------------------------------------------------------------------------------------------------
      QE Hand Off Template (fill out when moving to Review) 9/4/25:

      Summary of the Work: https://docs.google.com/document/d/1gOwZRZCG9zz1v5rQApzqSqtGNBNjgr5_nwb4m2u3zXs/edit?tab=t.0#heading=h.ea25ixk69ble

      • Split multiclusterhub_controller into multiple files
      • There should be no logical/functional changes

      Key Areas to Verify:

      • Since there were no functional changes, there are no key areas. ACM needs to run as normal, with no regressions in normal useage.

      Fix or Feature Availability:
      When will this be available in a build?
      Code merged on: 2025-09-04

              rh-ee-ngraham Nathaniel Graham
              cwall@redhat.com Cameron Wall
              Matthew Smigielski Matthew Smigielski
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: