Uploaded image for project: 'Red Hat Advanced Cluster Management'
  1. Red Hat Advanced Cluster Management
  2. ACM-19138

ArgoCD Pull Model should leverage the manifestwork ignoreFields for application propagation

XMLWordPrintable

    • Product / Portfolio Work
    • 5
    • False
    • Hide

      None

      Show
      None
    • False
    • Hide
      • [x] The Argo CD pull propagation controller is updated to leverage the new ManifestWork "ignoreFields" functionality.
      • [x] Add upstream ocm-io e2e testing.
      Show
      [x] The Argo CD pull propagation controller is updated to leverage the new ManifestWork "ignoreFields" functionality. [x] Add upstream ocm-io e2e testing.
    • Workload Mgmt Train 26 - 1, Workload Mgmt Train 26 - 2
    • Important
    • None

      Value Statement

      There is an issue with ManifestWork where an endless sync loop occurs when using the operation field in an ArgoCD Application CR deployed via a ManifestWork in a pull model setup

      In the pull model, the Application is deployed to the managed cluster via ManifestWork.
      If I modify that ManifestWork to contain
      #manifestwork payload:
      kind: Application
      spec: ...
      operation: ...
       

      Then the managed cluster will receive the operation field. However, when the Application controller on the managed cluster completes the sync and removes the operation field, the work agent adds it back, causing an endless sync.

      We need to leverage the new ManifestWork "ignoreFields" functionality to bypass this problem

      Definition of Done for Engineering Story Owner (Checklist)

      • The Argo CD pull propagation controller is updated to leverage the new ManifestWork "ignoreFields" functionality.
      • Add upstream ocm-io e2e testing.

      Development Complete

      • The code is complete.
      • Functionality is working.
      • Any required downstream Docker file changes are made.

      Tests Automated

      • [ ] Unit/function tests have been automated and incorporated into the
        build.
      • [ ] 100% automated unit/function test coverage for new or changed APIs.

      Secure Design

      • [ ] Security has been assessed and incorporated into your threat model.

      Multidisciplinary Teams Readiness

      • [ ] Create an informative documentation issue using the Customer

      Portal Doc template that you can access from [The Playbook](

      https://docs.google.com/document/d/1YTqpZRH54Bnn4WJ2nZmjaCoiRtqmrc2w6DdQxe_yLZ8/edit#heading=h.9fvyr2rdriby),

      and ensure doc acceptance criteria is met.

      • Call out this sentence as it's own action:
      • [ ] Link the development issue to the doc issue.

      Support Readiness

      • [ ] The must-gather script has been updated.

              ming@redhat.com Mike Ng
              ming@redhat.com Mike Ng
              David Huynh David Huynh
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: