Uploaded image for project: 'Red Hat Advanced Cluster Management'
  1. Red Hat Advanced Cluster Management
  2. ACM-14469

volsync-addon-controller - update to v0.10.0 of addon-framework (requires changes to maintain current behavior)

XMLWordPrintable

    • None

      Value Statement

      With ACM 2.13 we should be updating to at least v0.10.0 of the addon-framework.

       

      The volsync-addon-controller uses the addon-framework, but was not updated to v0.10.0 in the ACM 2.12 timeframe as there are breaking changes in the addon-framework.

       

      Some more detail here:  https://github.com/open-cluster-management-io/ocm/issues/616

       

      Essentially the current volsync-addon-framework allows users to install VolSync on a managed cluster in 2 ways:

       

      1. On the hub, they put the label "addons.open-cluster-management.io/volsync": "true" on the managed cluster resource for the managed cluster they want to deploy volsync to.  This then creates a volsync ManagedClusterAddOn in that managedcluster namespace and then deploys Volsync on that managed cluster.
      2. They create the volsync ManagedClusterAddOn themselves.

       

      Upgrading to v0.10.0 removes the installByLabel install strategy.  For the future The volsync-addon-controller will need to do the following:

      • use "Manual" install strategy type.
      • create another controller that will watch managedcluster resources and create the volsync ManagedClusterAddOn when the label is set as above in (1).

         

      Definition of Done for Engineering Story Owner (Checklist)

      • Current behaviour (1 and 2 above) needs to be maintained while moving to v0.10.0 (or later) of the addon-framework.

      Development Complete

      • The code is complete.
      • Functionality is working.
      • Any required downstream Docker file changes are made.

      Tests Automated

      • [ ] Unit/function tests have been automated and incorporated into the
        build.
      • [ ] 100% automated unit/function test coverage for new or changed APIs.

      Secure Design

      • [ ] Security has been assessed and incorporated into your threat model.

      Multidisciplinary Teams Readiness

      • [ ] Create an informative documentation issue using the Customer

      Portal Doc template that you can access from [The Playbook](

      https://docs.google.com/document/d/1YTqpZRH54Bnn4WJ2nZmjaCoiRtqmrc2w6DdQxe_yLZ8/edit#heading=h.9fvyr2rdriby),

      and ensure doc acceptance criteria is met.

      • Call out this sentence as it's own action:
      • [ ] Link the development issue to the doc issue.

      Support Readiness

      • [ ] The must-gather script has been updated.

              tflower@redhat.com Tesshu Flower
              tflower@redhat.com Tesshu Flower
              Thuy Nguyen Thuy Nguyen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: