Uploaded image for project: 'Red Hat Advanced Cluster Management'
  1. Red Hat Advanced Cluster Management
  2. ACM-13706

Avoid updating the cluster-monitoring-config when there is no change

XMLWordPrintable

    • 1
    • False
    • None
    • False
    • MCO Sprint 29, MCO Sprint 30, Observability Sprint 31, Observability Sprint 32
    • None

      Description of problem:

      The unnecessary update of the in-cluster prometheus configuration triggers unnecessary restarts. See https://redhat-internal.slack.com/archives/C0VMT03S5/p1722507107646839

      We should improve checks before effectively updating it. As it currently stands, we do the update on each reconcile loop. See https://github.com/stolostron/multicluster-observability-operator/blob/6f5dc9cba9274c52370d69d70678be454504ecc3/operators/endpointmetrics/controllers/observabilityendpoint/ocp_monitoring_config.go#L362-L422

       

      Version-Release number of selected component (if applicable):

      How reproducible:

      Steps to Reproduce:

      1.  
      2.  
      3. ...

      Actual results:

      Expected results:

      Additional info:

            rh-ee-tmange Thibault Mange
            rh-ee-tmange Thibault Mange
            Xiang Yin Xiang Yin
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated: