Uploaded image for project: 'Ansible Cloud Automation'
  1. Ansible Cloud Automation
  2. ACA-1263

[kubernetes.core/680] Helm diff does not use reuse-values

XMLWordPrintable

    • False
    • Hide

      None

      Show
      None
    • False

      https://github.com/ansible-collections/kubernetes.core/issues/680
      <!--- Verify first that your issue is not already reported on GitHub -->
      <!--- Also test if the latest release and devel branch are affected too -->
      <!--- Complete all sections as described, this form is processed automatically -->

              1. SUMMARY
                <!--- Explain the problem briefly below -->

      `kubernetes.core.helm` diff does not consider `reuse-values` to calculate the diff, resulting in inaccurate diffs.

              1. ISSUE TYPE
      • Bug Report
              1. COMPONENT NAME
                <!--- Write the short name of the module, plugin, task or feature below, use your best guess if unsure -->

      The [helmdiff_check](https://github.com/ansible-collections/kubernetes.core/blob/3.0.0/plugins/modules/helm.py#L632) signature differs from upgrades using [deploy](https://github.com/ansible-collections/kubernetes.core/blob/3.0.0/plugins/modules/helm.py#L490). `reuse_values`, for example, is missing.

      Recently merged changes (https://github.com/ansible-collections/kubernetes.core/pull/670) do not fully align the behavior.

              1. ANSIBLE VERSION
                <!--- Paste verbatim output from "ansible --version" between quotes -->
                ```paste below
                ansible [core 2.16.3]
                config file = None
                configured module search path = ['/home/ansible/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
                ansible python module location = /usr/local/lib/python3.11/site-packages/ansible
                ansible collection location = /home/ansible/.ansible/collections:/usr/share/ansible/collections
                executable location = /usr/local/bin/ansible
                python version = 3.11.5 (main, Sep 22 2023, 15:34:29) [GCC 8.5.0 20210514 (Red Hat 8.5.0-20)] (/usr/bin/python3)
                jinja version = 3.1.3
                libyaml = True
                ```
              1. COLLECTION VERSION
                <!--- Paste verbatim output from "ansible-galaxy collection list <namespace>.<collection>" between the quotes
                for example: ansible-galaxy collection list community.general
                -->
                ```paste below
      1. /home/ansible/.ansible/collections/ansible_collections
        Collection Version
                                  • -------
                                    kubernetes.core 3.0.0
      1. /usr/local/lib/python3.11/site-packages/ansible_collections
        Collection Version
                                  • -------
                                    kubernetes.core 2.4.0
                                    ```
              1. CONFIGURATION
                <!--- Paste verbatim output from "ansible-config dump --only-changed" between quotes -->
                ```paste below
                CONFIG_FILE() = /home/ansible/playbooks/ansible.cfg
                DEFAULT_MODULE_PATH(/home/ansible/playbooks/ansible.cfg) = ['/home/ansible/playbooks/library', '/home/ansible/playbooks/{{ ANSIBLE_HOME ~ "/plugins/modules', '/usr/share/ansible/plugins/modules" }}']
                ```
              1. OS / ENVIRONMENT
                <!--- Provide all relevant information below, e.g. target OS versions, network device firmware, etc. -->
              1. STEPS TO REPRODUCE
                <!--- Describe exactly how to reproduce the problem, using a minimal test-case -->

      Can add if required, any example with an existing helm release where values differ from defaults will do.

      <!--- Paste example playbooks or commands between quotes below -->
      ```yaml

      ```

      <!--- HINT: You can paste gist.github.com links for larger files -->

              1. EXPECTED RESULTS
                <!--- Describe what you expected to happen when running the steps above -->

      The diff output matches what would otherwise be achieved with `helm diff upgrade <...> --reuse-values <...>`

              1. ACTUAL RESULTS
                <!--- Describe what actually happened. If possible run with extra verbosity (-vvvv) -->

      Output as if running `helm diff upgrade <...>` without `--reuse-values`

            Unassigned Unassigned
            jrouleau Jill Rouleau
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: