Uploaded image for project: 'Ansible Automation Platform RFEs'
  1. Ansible Automation Platform RFEs
  2. AAPRFE-1185

Security risk introduced by AAP following github redirects

XMLWordPrintable

    • Icon: Feature Request Feature Request
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • 2.4
    • controller
    • False
    • Hide

      None

      Show
      None
    • False

      1. What is the nature and description of the request?

      Considering the following scenario:

      1. AAP Organization admin sets up a github project in AAP, specifying the SCM URL and branch.
      2. Sometime later, the owner of the content on github changes the path to the content
      3. The next time the AAP project is refreshed, AAP will send a request to the "old" github URL
      4. Github responds with a redirect
      5. AAP follows the redirect and finds the content at the new location, the org admin is unaware that the URL is outdated

      6. A malicious actor uploads malicious content to the "old" github URL
      7. The next time the AAP project is refreshed, AAP will send a request to the "old" URL
      8. Github sends the malicious content to AAP and AAP updates with the malicious content

      The redirect from the github repository is performed by github and customer would like to get some notification about the change of the SCM repository.

      Customer wants this RFE to ask that the AAP Admin be able to select from the following responses to an SCM redirect:

      1.  Follow unconditionally - the current approach, the problem remains
      2. Follow but send a notification to the org and project admin that the URL should be changed - the problem remains until the project definition is updated
      3. Automatically update the SCM URL in the project to the new value and refresh from the new URL - problem solved when detected
      4. Fail the refresh, blank the SCM URL in the project, and explain in the  error message that the URL should be changed to the new value

       

      1. Why does the customer need this? (List the business requirements here)

      Security concern.

      1. How would you like to achieve this? (List the functional requirements here)
      2. List any affected known dependencies: Doc, UI etc..
      3. Github Link if any

              bcoursen@redhat.com Brian Coursen
              rhn-support-fjaimesc Felix Itzel Jaimes Campos
              Votes:
              1 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated: