Uploaded image for project: 'Automation Hub'
  1. Automation Hub
  2. AAH-2080

galaxy_ng api group roles endpoints not functional

    • Icon: Bug Bug
    • Resolution: Not a Bug
    • Icon: Undefined Undefined
    • None
    • 2.3
    • Pulp
    • None
    • False
    • Hide

      None

      Show
      None
    • False

      Description

      The following endpoints on either PAH or galaxy_ng do not work:
      api/automation-hub/pulp/api/v3/groups/4/list_roles/
      api/automation-hub/pulp/api/v3/groups/4/add_role/
      api/automation-hub/pulp/api/v3/groups/4/remove_role/
      api/automation-hub/pulp/api/v3/groups/4/my_permissions/

      They need access control statements added to each endpoint
      believe to be here
      https://github.com/ansible/galaxy_ng/blob/master/galaxy_ng/app/access_control/statements/standalone.py

      for example we assign access to GroupViewSet but not groups since our app does not use that right now https://github.com/ansible/galaxy_ng/blob/master/galaxy_ng/app/access_control/statements/standalone.py#L402

      Key Dependency Versions

      {"available_versions":

      {"v3": "v3/","pulp-v3": "pulp/api/v3/"}

      ,"server_version": "4.7.0dev","galaxy_ng_version": "4.7.0dev","galaxy_ng_commit": "","galaxy_importer_version": "0.4.6","pulp_core_version": "3.21.3","pulp_ansible_version": "0.16.0","pulp_container_version": "2.14.1"}

      Also tested on
      Server version 4.6.2
      Pulp Ansible Version 0.15.0
      UI Version 4.6.2

      Steps to Reproduce

      Endpoint: api/automation-hub/pulp/api/v3/groups/4/list_roles/

      {"roles": []}

      Endpoint:  api/automation-hub/pulp/api/v3/groups/4/add_role/

      {"non_field_errors": ["The role does not contain any permission for that object."]}

      or

      {"users": [],"groups": [],"role": "core.group_creator"}

      But this does not add a role

      Endpoint: api/automation-hub/pulp/api/v3/groups/4/remove_role/

      {"non_field_errors": ["The role does not contain any permission for that object."]}

      Endpoint: api/automation-hub/pulp/api/v3/groups/2/my_permissions/

      {"permissions": []}

      Even though it has 3 roles with over 10 permissions in the GUI.

      Actual Behavior

      Nothing, nothing is changing

      Expected Behavior

      The different endpoints should function,
      List roles -> lists roles for the group
      add_role -> add role to the group
      remove_role -> remove role in the group
      my_permisions -> ??? same as list?

              dnewswan David Newswanger
              rhn-gps-ssulliva Sean Sullivan
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Created:
                Updated:
                Resolved: