Loading...

XML

Word

Printable

Blocked:
False
Ready:
False
RCA Description:

Hide
* *Why we missed the bug?*
** Pick to proper answer from drop-down field upper.
+_Additional comments:_+

* *What is required:*
** Pick to proper answer from drop-down field upper.
+_Additional comments:_+

Show
* *Why we missed the bug?* ** Pick to proper answer from drop-down field upper. +_Additional comments:_+ * *What is required:* ** Pick to proper answer from drop-down field upper. +_Additional comments:_+
Git Pull Request:
https://github.com/windup/windup/pull/1439
[QE] How to address?:
---
[QE] Why QE missed?:
---

Some refactoring of core classes done as part of my ongoing journey to understand the codebase:

TechnologyReferenceTransformer* -> TechnologyReferenceAliasTranslator*. Could be further renamed to TechnologyAliasTranslator. I think it better tells what this set of classes do. Further refactoring would potentially be needed to also change the name of the xml files that contain the translation.
RuleLoaderImpl, WindupProcessorImpl: extraction of blocks of code into methods to better show what they do.
Rewriting of some expressions into lambdas.
Renaming of some variables.
Elimination of dead code.