Uploaded image for project: 'JBoss Enterprise Application Platform'
  1. JBoss Enterprise Application Platform
  2. JBEAP-20272

No autoupdate for EAP_RUNTIME_IMAGE in eap-s2i-build template

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Obsolete
    • Icon: Major Major
    • None
    • None
    • OpenShift
    • None
    • False
    • False
    • +
    • Undefined
    • Hide

      Analysis provides this information:

      Test EAP S2I image changes
      - Import a more recent version of EAP S2I images (test should be done for both the builder and runtime images referenced by the imagestreams)
      

      However, in current template configuration there is no trigger upon EAP_RUNTIME_IMAGE imagestream change.

      This is obvious why it doesn't happen when we look into template:
      bc ${APPLICATION_IMAGE}-build-artifacts - https://github.com/jmesnil/jboss-eap-openshift-templates/blob/eap-s2i-build_template/eap-s2i-build.yaml#L68-L77

          triggers:
          - github:
              secret: ${GITHUB_WEBHOOK_SECRET}
            type: GitHub
          - generic:
              secret: ${GENERIC_WEBHOOK_SECRET}
            type: Generic
          - imageChange: {}
            type: ImageChange
          - type: ConfigChange
      

      bc ${APPLICATION_IMAGE} - https://github.com/jmesnil/jboss-eap-openshift-templates/blob/eap-s2i-build_template/eap-s2i-build.yaml#L110-L116

          triggers:
          - imageChange:
              from:
                kind: ImageStreamTag
                name: ${APPLICATION_IMAGE}-build-artifacts:latest
            type: ImageChange
          - type: ConfigChange
      

      -> no trigger for EAP_RUNTIME_IMAGE imagestream changes

      So now the expectation (rebuild app image on both builder or runtime image change) is broken.

      Show
      Analysis provides this information: Test EAP S2I image changes - Import a more recent version of EAP S2I images (test should be done for both the builder and runtime images referenced by the imagestreams) However, in current template configuration there is no trigger upon EAP_RUNTIME_IMAGE imagestream change. This is obvious why it doesn't happen when we look into template: bc ${APPLICATION_IMAGE}-build-artifacts - https://github.com/jmesnil/jboss-eap-openshift-templates/blob/eap-s2i-build_template/eap-s2i-build.yaml#L68-L77 triggers: - github: secret: ${GITHUB_WEBHOOK_SECRET} type: GitHub - generic : secret: ${GENERIC_WEBHOOK_SECRET} type: Generic - imageChange: {} type: ImageChange - type: ConfigChange bc ${APPLICATION_IMAGE} - https://github.com/jmesnil/jboss-eap-openshift-templates/blob/eap-s2i-build_template/eap-s2i-build.yaml#L110-L116 triggers: - imageChange: from: kind: ImageStreamTag name: ${APPLICATION_IMAGE}-build-artifacts:latest type: ImageChange - type: ConfigChange -> no trigger for EAP_RUNTIME_IMAGE imagestream changes So now the expectation (rebuild app image on both builder or runtime image change) is broken.

            jmesnil1@redhat.com Jeff Mesnil
            jbliznak@redhat.com Jan Blizňák
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: