Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-9908

Unused PathAddress variable in BroadcastGroupAdd.performRuntime method

    XMLWordPrintable

Details

    Description

      Variable final PathAddress address in method BroadcastGroupAdd.performRuntime is declared but never used.

          @Override
          protected void performRuntime(OperationContext context, ModelNode operation, ModelNode model) throws OperationFailedException {
              ...
              else {
                  final PathAddress address = context.getCurrentAddress();
                  final String name = context.getCurrentAddressValue();
      
                  final ServiceTarget target = context.getServiceTarget();
                  if (model.hasDefined(JGROUPS_CLUSTER.getName())) {
                      // nothing to do, in that case, the clustering.jgroups subsystem will have setup the stack
                  } else if(model.hasDefined(RemoteTransportDefinition.SOCKET_BINDING.getName())) {
                      final GroupBindingService bindingService = new GroupBindingService();
                      target.addService(GroupBindingService.getBroadcastBaseServiceName(serviceName).append(name), bindingService)
                              .addDependency(SocketBinding.JBOSS_BINDING_NAME.append(model.get(SOCKET_BINDING).asString()), SocketBinding.class, bindingService.getBindingRef())
                              .install();
                  }
              }
      } 
      

      https://github.com/wildfly/wildfly/blame/master/messaging-activemq/src/main/java/org/wildfly/extension/messaging/activemq/BroadcastGroupAdd.java#L129

      Attachments

        Activity

          People

            rhn-engineering-rhusar Radoslav Husar
            mstyk_jira Martin Styk (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: