Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-9433

Apply InfiniteOrPositiveValidators to messaging attributes allow valid value -1

    XMLWordPrintable

    Details

      Description

      There are several attributes defined from ActiveMQ Artemis configuration parameters in ActiveMQClient.java and ActiveMQDefaultConfiguration.java are allowed to take value -1.

      As they miss proper InfiniteOrPositiveValidators, they can also take any negative values which is incorrect.

      ActiveMQClient.java
      public static final long DEFAULT_CLIENT_FAILURE_CHECK_PERIOD_INVM = -1;
      public static final long DEFAULT_CONNECTION_TTL_INVM = -1;
      public static final int DEFAULT_CONSUMER_MAX_RATE = -1;
      public static final int DEFAULT_CONFIRMATION_WINDOW_SIZE = -1;
      public static final int DEFAULT_PRODUCER_MAX_RATE = -1;
      public static final int DEFAULT_THREAD_POOL_MAX_SIZE = -1;
      
      
      ActiveMQDefaultConfiguration.java
      private static long DEFAULT_CONNECTION_TTL_OVERRIDE = -1;
      private static int DEFAULT_JOURNAL_POOL_FILES = -1;
      private static long DEFAULT_CONNECTION_TTL_OVERRIDE = -1;
      private static int DEFAULT_JOURNAL_PERF_BLAST_PAGES = -1;
      private static long DEFAULT_SERVER_DUMP_INTERVAL = -1;
      private static long DEFAULT_MEMORY_MEASURE_INTERVAL = -1;
      private static int DEFAULT_BRIDGE_INITIAL_CONNECT_ATTEMPTS = -1;
      private static int DEFAULT_BRIDGE_RECONNECT_ATTEMPTS = -1;
      private static int DEFAULT_BRIDGE_PRODUCER_WINDOW_SIZE = -1;
      private static int DEFAULT_CLUSTER_INITIAL_CONNECT_ATTEMPTS = -1;
      private static int DEFAULT_CLUSTER_RECONNECT_ATTEMPTS = -1;
      private static int DEFAULT_HAPOLICY_BACKUP_REQUEST_RETRIES = -1;
      private static int DEFAULT_GROUPING_HANDLER_GROUP_TIMEOUT = -1;
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              chaowan@redhat.com Chao Wang
              Reporter:
              chaowan@redhat.com Chao Wang
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: