Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-8867

Legacy protocol property resource operations do not work for legacy protocols

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Blocker
    • Resolution: Done
    • 11.0.0.Alpha1
    • 11.0.0.Beta1
    • Clustering
    • None
    • Hide

      DR18 and DR19 changed how JGroups protocols are configured.

      legacy configuration
      /subsystem=jgroups/stack=tcpping/protocol=TCPPING:add()
      /subsystem=jgroups/stack=tcpping/protocol=TCPPING/property=initial_hosts:add(value=192.168.10.1[7600],192.168.10.2[7600])
      
      configuration change with DR19
      /subsystem=jgroups/stack=tcpping/protocol=TCPPING:add()
      /subsystem=jgroups/stack=tcpping/protocol=org.jgroups.protocols.TCPPING/property=initial_hosts:add(value=192.168.10.1[7600],192.168.10.2[7600])
      # the old commands do not run
      

      Affected protocols are at least TCPPING, SYM_ENCRYPT, ASYM_ENCRYPT and with DR19 maybe also AUTH (haven't tried this one yet).

      Additionally, the add-protocol operation no longer works with legacy configuration. Yes, it is deprecated, but if other operations should be backward compatible, this should be as well.

      legacy configuration
      /subsystem="jgroups"/stack="tcpping":add-protocol(type="TCPPING")
      # because:
      # Operation: /subsystem=jgroups/stack=tcpping:add-protocol(type="TCPPING")
      # Failure: WFLYCTL0155: 'socket-bindings' may not be null
      

      Full sets of commands:
      does not work: http://pastebin.test.redhat.com/488602
      works: http://pastebin.test.redhat.com/488646

      Show
      DR18 and DR19 changed how JGroups protocols are configured. legacy configuration /subsystem=jgroups/stack=tcpping/protocol=TCPPING:add() /subsystem=jgroups/stack=tcpping/protocol=TCPPING/property=initial_hosts:add(value=192.168.10.1[7600],192.168.10.2[7600]) configuration change with DR19 /subsystem=jgroups/stack=tcpping/protocol=TCPPING:add() /subsystem=jgroups/stack=tcpping/protocol=org.jgroups.protocols.TCPPING/property=initial_hosts:add(value=192.168.10.1[7600],192.168.10.2[7600]) # the old commands do not run Affected protocols are at least TCPPING, SYM_ENCRYPT, ASYM_ENCRYPT and with DR19 maybe also AUTH (haven't tried this one yet). Additionally, the add-protocol operation no longer works with legacy configuration. Yes, it is deprecated, but if other operations should be backward compatible, this should be as well. legacy configuration /subsystem="jgroups"/stack="tcpping":add-protocol(type="TCPPING") # because: # Operation: /subsystem=jgroups/stack=tcpping:add-protocol(type="TCPPING") # Failure: WFLYCTL0155: 'socket-bindings' may not be null Full sets of commands: does not work: http://pastebin.test.redhat.com/488602 works: http://pastebin.test.redhat.com/488646

    Description

      QE Cc mnovak1@redhat.com, okalman@redhat.com, mstyk_jira, pkremens@redhat.com
      Cc kkhan1@redhat.com, jgreene@redhat.com

      See steps to reproduce. The question is, to what degree should CLI commands be backward compatible with 7.0? XML configurations pasted from 7.0 are OK in this case.

      I previously thought these changes were OK (once documented in migration guide), but after discussion with the rest of the QE team, the most common opinion is that CLI commands should be 100% backward compatible with 7.0, which is not the case here.

      bozpeyni@redhat.com since this is not stated anywhere I know, can you confirm that CLI commands in 7.1 need to be backward compatible with 7.0?

      Attachments

        Issue Links

          Activity

            People

              pferraro@redhat.com Paul Ferraro
              pferraro@redhat.com Paul Ferraro
              Richard Janik Richard Janik
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: