Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-20795

Remove com.google.code.gson dependency from io.netty.netty-code-http2 module

XMLWordPrintable

      Netty's code-http2 only uses google gson as a test dep, so we don't need to declare it as a runtime dependency.

      This will leave Hibernate Search as the only use of google gson, so in many slimmed server scenarios we'll avoid provisioning a 258K jar file.

      In checkout of the netty tag currently used in WF:

      $ git grep gson | grep java
      codec-http2/src/test/java/io/netty/handler/codec/http2/HpackTestCase.java:import com.google.gson.FieldNamingPolicy;
      codec-http2/src/test/java/io/netty/handler/codec/http2/HpackTestCase.java:import com.google.gson.Gson;
      codec-http2/src/test/java/io/netty/handler/codec/http2/HpackTestCase.java:import com.google.gson.GsonBuilder;
      codec-http2/src/test/java/io/netty/handler/codec/http2/HpackTestCase.java:import com.google.gson.JsonDeserializationContext;
      codec-http2/src/test/java/io/netty/handler/codec/http2/HpackTestCase.java:import com.google.gson.JsonDeserializer;
      codec-http2/src/test/java/io/netty/handler/codec/http2/HpackTestCase.java:import com.google.gson.JsonElement;
      codec-http2/src/test/java/io/netty/handler/codec/http2/HpackTestCase.java:import com.google.gson.JsonObject;
      codec-http2/src/test/java/io/netty/handler/codec/http2/HpackTestCase.java:import com.google.gson.JsonParseException;
      transport/src/test/java/io/netty/nativeimage/ChannelHandlerMetadataUtil.java:import com.google.gson.Gson;
      transport/src/test/java/io/netty/nativeimage/ChannelHandlerMetadataUtil.java:import com.google.gson.GsonBuilder;
      transport/src/test/java/io/netty/nativeimage/ChannelHandlerMetadataUtil.java:import com.google.gson.reflect.TypeToken;
      transport/src/test/java/io/netty/nativeimage/ChannelHandlerMetadataUtil.java:    private static final Gson gson = new GsonBuilder().setPrettyPrinting().create();
      transport/src/test/java/io/netty/nativeimage/ChannelHandlerMetadataUtil.java:            existingMetadata = gson.fromJson(reader, HANDLER_METADATA_LIST_TYPE);
      transport/src/test/java/io/netty/nativeimage/ChannelHandlerMetadataUtil.java:        return gson.toJson(metadataList, HANDLER_METADATA_LIST_TYPE);
      

      In Netty's parent pom dependencyManagement, google gson is listed as a test dep for http2.

              bstansbe@redhat.com Brian Stansberry
              bstansbe@redhat.com Brian Stansberry
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: