Uploaded image for project: 'WildFly'
  1. WildFly
  2. WFLY-14057

ManagedExecutorServiceImpl not consistent with AbstractManagedExecutorServiceAdapter

    XMLWordPrintable

Details

    • Bug
    • Resolution: Not a Bug
    • Major
    • None
    • 21.0.0.Final
    • Concurrency Utilities, EE
    • None

    Description

      The current org.jboss.as.ee.concurrent.ManagedExecutorServiceImpl extends org.glassfish.enterprise.concurrent.ManagedExecutorServiceImpl to take advantage out of the provided implementation. Regarding to the API doc, it would be necessary to extend org.glassfish.enterprise.concurrent.AbstractManagedExecutorServiceAdapter instead. This would protect the container thread pools from lifecycle calls of user code. But it would lack the implementation of o.g.e.c.ManagedExecutorServiceImpl.

      I suggest to adopt the o.g.e.c.AbstractManagedExecutorServiceAdapter methods to the o.j.a.e.c.ManagedExecutorServiceImpl.
      If not, it would be good to have an API doc explaining why it is OK to call lifecycle methods from user code for the WildFly implementation.
       

      Attachments

        Activity

          People

            emartins@redhat.com Eduardo Martins
            xf01213 Boris Unckel (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: