Loading...

Details

Type: Bug
Resolution: Unresolved
Priority: Major
Fix Version/s: None
Affects Version/s: 16.0.0.Final
Component/s: Web (Undertow)
Labels:
None

Story Points:
5
Steps to Reproduce:

Hide

create a jsp Page
1. import JSTL core libraray <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
2. create a bean object com.akash.Person and add
<jsp:useBean id="Person" class="com.akashPerson" scope="session"/>
3 . write JSTL evaluation ${Person.name}

try to lunach the wildlfy server with deployed JSP in windows machine
it will throw the above error mention in the description

Probable Fix Required in class
org.apache.jasper.el.JasperELResolver.java of jastow-2.0.17.final.jar

the below code add resolvers to resolve the object defined for JSTL evulation

add(new ImplicitObjectELResolver());
for (ELResolver appResolver : appResolvers)
{ add(appResolver); }
add(streamResolver);
add(new StaticFieldELResolver());
add(new MapELResolver());
add(new ResourceBundleELResolver());
add(new ListELResolver());
add(new ArrayELResolver());
add(new BeanELResolver());
add(new ScopedAttributeELResolver());

appResolvers - contains ImportedClassELResolver

added as part of wildfly-undertow-16.0.0.jar

@Override
public void contextInitialized(final ServletContextEvent sce) {
// if the servlet version is 3.1 or higher, setup a ELResolver which allows usage of static fields java.lang.*
final ServletContext servletContext = sce.getServletContext();
final JspApplicationContext jspApplicationContext = JspFactory.getDefaultFactory().getJspApplicationContext(servletContext);
if (servletContext.getEffectiveMajorVersion() > 3
|| (servletContext.getEffectiveMajorVersion() == 3 && servletContext.getEffectiveMinorVersion() >= 1)) { jspApplicationContext.addELResolver(new ImportedClassELResolver()); }
// setup a wrapped JspApplicationContext if there are any EL expression factory wrappers for this servlet context
final List<ExpressionFactoryWrapper> expressionFactoryWrappers = (List<ExpressionFactoryWrapper>) sce.getServletContext().getAttribute(CONTEXT_KEY);
if (expressionFactoryWrappers != null && !expressionFactoryWrappers.isEmpty()) { final JspApplicationContextWrapper jspApplicationContextWrapper = new JspApplicationContextWrapper(JspApplicationContextImpl.getInstance(servletContext), expressionFactoryWrappers, sce.getServletContext()); sce.getServletContext().setAttribute(JspApplicationContextImpl.class.getName(), jspApplicationContextWrapper); }
}

it will try to think Person class as a Constant Class instead of bean Class instance beacause ImportedClassELResolver is higher in the order and throws the error "name" is not accessible and it will throw the PropertyNotFoundException
because a constant class property should be public static

Fix can be to catch to put ImportedClassELResolver at last so first all objects get resolved then static Constant import class should get resolved

add(new ImplicitObjectELResolver());
add(streamResolver);
add(new StaticFieldELResolver());
add(new MapELResolver());
add(new ResourceBundleELResolver());
add(new ListELResolver());
add(new ArrayELResolver());
add(new BeanELResolver());
add(new ScopedAttributeELResolver());
for (ELResolver appResolver : appResolvers) { add(appResolver); }

Show
create a jsp Page 1. import JSTL core libraray <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %> 2. create a bean object com.akash.Person and add <jsp:useBean id="Person" class="com.akashPerson" scope="session"/> 3 . write JSTL evaluation ${Person.name} try to lunach the wildlfy server with deployed JSP in windows machine it will throw the above error mention in the description Probable Fix Required in class org.apache.jasper.el.JasperELResolver.java of jastow-2.0.17.final.jar the below code add resolvers to resolve the object defined for JSTL evulation add(new ImplicitObjectELResolver()); for (ELResolver appResolver : appResolvers) { add(appResolver); } add(streamResolver); add(new StaticFieldELResolver()); add(new MapELResolver()); add(new ResourceBundleELResolver()); add(new ListELResolver()); add(new ArrayELResolver()); add(new BeanELResolver()); add(new ScopedAttributeELResolver()); appResolvers - contains ImportedClassELResolver added as part of wildfly-undertow-16.0.0.jar @Override public void contextInitialized(final ServletContextEvent sce) { // if the servlet version is 3.1 or higher, setup a ELResolver which allows usage of static fields java.lang.* final ServletContext servletContext = sce.getServletContext(); final JspApplicationContext jspApplicationContext = JspFactory.getDefaultFactory().getJspApplicationContext(servletContext); if (servletContext.getEffectiveMajorVersion() > 3 || (servletContext.getEffectiveMajorVersion() == 3 && servletContext.getEffectiveMinorVersion() >= 1)) { jspApplicationContext.addELResolver(new ImportedClassELResolver()); } // setup a wrapped JspApplicationContext if there are any EL expression factory wrappers for this servlet context final List<ExpressionFactoryWrapper> expressionFactoryWrappers = (List<ExpressionFactoryWrapper>) sce.getServletContext().getAttribute(CONTEXT_KEY); if (expressionFactoryWrappers != null && !expressionFactoryWrappers.isEmpty()) { final JspApplicationContextWrapper jspApplicationContextWrapper = new JspApplicationContextWrapper(JspApplicationContextImpl.getInstance(servletContext), expressionFactoryWrappers, sce.getServletContext()); sce.getServletContext().setAttribute(JspApplicationContextImpl.class.getName(), jspApplicationContextWrapper); } } it will try to think Person class as a Constant Class instead of bean Class instance beacause ImportedClassELResolver is higher in the order and throws the error "name" is not accessible and it will throw the PropertyNotFoundException because a constant class property should be public static Fix can be to catch to put ImportedClassELResolver at last so first all objects get resolved then static Constant import class should get resolved add(new ImplicitObjectELResolver()); add(streamResolver); add(new StaticFieldELResolver()); add(new MapELResolver()); add(new ResourceBundleELResolver()); add(new ListELResolver()); add(new ArrayELResolver()); add(new BeanELResolver()); add(new ScopedAttributeELResolver()); for (ELResolver appResolver : appResolvers) { add(appResolver); }
Workaround:

Workaround Exists
Workaround Description:

Hide

use ${sessionScope.Person.name} instead of ${Person.name}
it will go to the first ImplicitObjectELResolver and ImportedClassELRsolver will not take the effect

Show
use ${sessionScope.Person.name} instead of ${Person.name} it will go to the first ImplicitObjectELResolver and ImportedClassELRsolver will not take the effect
Estimated Difficulty:
Medium

Description

Following is the stacktrace

2019/10/23 16:43:33 INFO [stdout]

{webui}

[default task-24] 75 exception_jsp: Error in web. UUID:41f0fb82-fd7a-42bc-8df6-61f40e3aa989 User: ID:1 UserName:akash - org.apache.jasper.JasperException: javax.el.PropertyNotFoundException: Either 'name' is not a public static field of the class 'com.akash.nas.web.query.Person' or field is inacessable

2019/10/23 16:43:33 INFO [stdout] at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:473)

2019/10/23 16:43:33 INFO [stdout] at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:403)

2019/10/23 16:43:33 INFO [stdout] at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:347)

2019/10/23 16:43:33 INFO [stdout] at javax.servlet.http.HttpServlet.service(HttpServlet.java:791)
2019/10/23 16:43:33 INFO [stdout] at io.undertow.servlet.handlers.ServletHandler.handleRequest(ServletHandler.java:74)

2019/10/23 16:43:33 INFO [stdout] at io.undertow.servlet.handlers.FilterHandler.handleRequest(FilterHandler.java:81)

2019/10/23 16:43:33 INFO [stdout] at io.undertow.servlet.handlers.security.ServletSecurityRoleHandler.handleRequest(ServletSecurityRoleHandler.java:62)

2019/10/23 16:43:33 INFO [stdout] at io.undertow.jsp.JspFileHandler.handleRequest(JspFileHandler.java:32)

2019/10/23 16:43:33 INFO [stdout] at io.undertow.servlet.handlers.ServletChain$1.handleRequest(ServletChain.java:68)

2019/10/23 16:43:33 INFO [stdout] at io.undertow.servlet.handlers.ServletDispatchingHandler.handleRequest(ServletDispatchingHandler.java:36)

2019/10/23 16:43:33 INFO [stdout] at io.undertow.server.handlers.PredicateHandler.handleRequest(PredicateHandler.java:43)

2019/10/23 16:43:33 INFO [stdout] at io.undertow.servlet.handlers.ServletInitialHandler.dispatchRequest(ServletInitialHandler.java:274)

2019/10/23 16:43:33 INFO [stdout] at io.undertow.servlet.handlers.ServletInitialHandler.dispatchToServlet(ServletInitialHandler.java:219)

2019/10/23 16:43:33 INFO [stdout] at io.undertow.servlet.spec.RequestDispatcherImpl.includeImpl(RequestDispatcherImpl.java:392)

2019/10/23 16:43:33 INFO [stdout] at io.undertow.servlet.spec.RequestDispatcherImpl.setupIncludeImpl(RequestDispatcherImpl.java:327)

2019/10/23 16:43:33 INFO [stdout] at io.undertow.servlet.spec.RequestDispatcherImpl.include(RequestDispatcherImpl.java:291)

2019/10/23 16:43:33 INFO [stdout] at org.apache.jasper.runtime.JspRuntimeLibrary.include(JspRuntimeLibrary.java:907)

2019/10/23 16:43:33 INFO [stdout] at org.apache.jsp.query.generic.query_resultpage_jsp._jspService(query_resultpage_jsp.java:96)

2019/10/23 16:43:33 INFO [stdout] at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)

2019/10/23 16:43:33 INFO [stdout] at javax.servlet.http.HttpServlet.service(HttpServlet.java:791)
2019/10/23 16:43:33 INFO [stdout] at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:433)