Uploaded image for project: 'JBoss WFK 2'
  1. JBoss WFK 2
  2. WFK2-702

kitchensink-html5-mobile quickstart profiles

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Done
    • Affects Version/s: 2.6.0.CR1
    • Fix Version/s: 2.7.0.CR1
    • Component/s: None
    • Labels:

      Description

      There is written in the README.md file in the paragraph "Minification":

      NOTE: You must either specify the default profile for no tests or the arquillian test profile to run tests when minifying to avoid test errors. For example:

      #No Tests
      mvn clean package jboss-as:deploy -Pminify,default

      However, the tests are skipped even if the "default" profile isn't specified. That's because the "minify" profile contains a configuration of the maven-surefire-plugin with the skip configuration set to true.
      https://github.com/jboss-developer/jboss-wfk-quickstarts/blob/2.6.x/kitchensink-html5-mobile/pom.xml#L276-L282

      The README.md file should be definitely changed and I would recommend to change the configuration of the test skipping in the pom file as well.

      I would suggest to move the configuration of the maven-surefire-plugin

      <plugin>
          <artifactId>maven-surefire-plugin</artifactId>
          <version>${version.surefire.plugin}</version>
          <configuration>
              <skip>true</skip>
          </configuration>
      </plugin>
      

      from the "default" profile (this profile remove at all) to the main build part of the pom and remove it from the "minife" profile. The tests will be always skipped, so in the both profiles "arq-jbossas-managed" and "arq-jbossas-remote" should be the configuration rewritten:

      <plugin>
          <artifactId>maven-surefire-plugin</artifactId>
          <version>${version.surefire.plugin}</version>
          <configuration>
              <skip>false</skip>
          </configuration>
      </plugin>
      

      What will be the benefits of these changes?
      1. The profile will IMHO more understandable for the beginners (test are launched only when they are needed - in the two profiles, otherwise they are skipped)
      2. And, MAINLY, there won't be needed so crazy configuration in the archetype as it is now:
      https://github.com/jboss-developer/jboss-wfk-archetypes/blob/2.6.x-develop/jboss-html5-mobile-archetype/src/main/resources/archetype-resources/pom.xml

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  manaRH Marek Novotny
                  Reporter:
                  mjobanek Matous Jobanek
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  4 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: