Uploaded image for project: 'Red Hat 3scale API Management'
  1. Red Hat 3scale API Management
  2. THREESCALE-4336

Remove the gem for protected attributes

    XMLWordPrintable

Details

    • Enhancement
    • Resolution: Duplicate
    • Minor
    • None
    • None
    • System
    • Not Started
    • Not Started
    • Not Started
    • Not Started
    • Not Started
    • Not Started
    • Engineering

    Description

      Protected attributes gem is the old way to ensure that some attributes of the model are not updated from the outside world. The new way is strong params in the controller.

      Protected attributes gem overrides Active Record methods in a dangerous way, which is not nice and does not suit well with Baby Squeel either. For that, we are overwriting those methods once more for them to contain the code that they had originally in Rails 5.

      I (Marta) think that we should get rid of the protected attributes gem and refactor to only use strong params instead. But I am aware that this can be a lot of work to make sure that we are covering everything properly.

      But maybe I am wrong in the proper approach.

      Either way, we need to discuss about it to know what is the best thing to do in our case Maybe we are already doing as we should

      Attachments

        Activity

          People

            Unassigned Unassigned
            mnoyabon Marta Noya (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: