Uploaded image for project: 'Thorntail'
  1. Thorntail
  2. THORN-2542

MP Metrics output not spec compliant

    Details

    • Story Points:
      1
    • Steps to Reproduce:
      Hide

      Check any instance, e.g. via:

      curl http://localhost:8080/metrics
      

      Observe output:

      ...
      # HELP vendor_memoryPool_usage_max_bytes Peak usage of the memory pool
      # TYPE vendor_memoryPool_usage_max_bytes gauge
      vendor_memoryPool_usage_max_bytes{name="G1 Old Gen"} 8.850176E7
      vendor_memoryPool_usage_bytes{name="Compressed Class Space1"} 1.8096592E7
      vendor_memoryPool_usage_bytes{name="G1 Old Gen1"} 8.2649288E7
      vendor_memoryPool_usage_bytes{name="G1 Survivor Space1"} 1.3631488E7
      vendor_memoryPool_usage_max_bytes{name="G1 Survivor Space"} 2.097152E7
      # HELP vendor_bufferPool_usedMemory_bytes Memory used by the NIO pool
      # TYPE vendor_bufferPool_usedMemory_bytes gauge
      vendor_bufferPool_usedMemory_bytes{name="direct"} 385102.0
      vendor_memoryPool_usage_bytes{name="CodeHeap 'non-nmethods'1"} 1404160.0
      vendor_memoryPool_usage_max_bytes{name="CodeHeap 'non-nmethods'"} 3199232.0
      vendor_memoryPool_usage_bytes{name="G1 Eden Space1"} 8.5983232E7
      vendor_memoryPool_usage_max_bytes{name="Metaspace"} 1.41406128E8
      ...
      

      All vendor_memoryPool_usage... entries should be grouped together under their

      # TYPE vendor_memoryPool_usage_max_bytes gauge

      heading.

      Show
      Check any instance, e.g. via: curl http: //localhost:8080/metrics Observe output: ... # HELP vendor_memoryPool_usage_max_bytes Peak usage of the memory pool # TYPE vendor_memoryPool_usage_max_bytes gauge vendor_memoryPool_usage_max_bytes{name="G1 Old Gen"} 8.850176E7 vendor_memoryPool_usage_bytes{name="Compressed Class Space1"} 1.8096592E7 vendor_memoryPool_usage_bytes{name="G1 Old Gen1"} 8.2649288E7 vendor_memoryPool_usage_bytes{name="G1 Survivor Space1"} 1.3631488E7 vendor_memoryPool_usage_max_bytes{name="G1 Survivor Space"} 2.097152E7 # HELP vendor_bufferPool_usedMemory_bytes Memory used by the NIO pool # TYPE vendor_bufferPool_usedMemory_bytes gauge vendor_bufferPool_usedMemory_bytes{name="direct"} 385102.0 vendor_memoryPool_usage_bytes{name="CodeHeap 'non-nmethods'1"} 1404160.0 vendor_memoryPool_usage_max_bytes{name="CodeHeap 'non-nmethods'"} 3199232.0 vendor_memoryPool_usage_bytes{name="G1 Eden Space1"} 8.5983232E7 vendor_memoryPool_usage_max_bytes{name="Metaspace"} 1.41406128E8 ... All vendor_memoryPool_usage... entries should be grouped together under their # TYPE vendor_memoryPool_usage_max_bytes gauge heading.

      Description

      SmallRye Metrics output does not conform to https://prometheus.io/docs/instrumenting/exposition_formats/#grouping-and-sorting as discussed in https://github.com/smallrye/smallrye-metrics/issues/170 (requires re-opening).

      Makes Metrics with Tags unusable.

      Upgraded version of Thorntail is required with fixed SmallRye Metrics.

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                lthon Ladislav Thon
                Reporter:
                jim_b_o James Olsen
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: