Uploaded image for project: 'Thorntail'
  1. Thorntail
  2. THORN-2538

Use of thorntail.runner.webapp-location generates a invalid WAR

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: 2.6.0.Final
    • Fix Version/s: 2.7.0.Final
    • Component/s: runner
    • Labels:
      None
    • Story Points:
      1
    • Steps to Reproduce:
      Hide

      Point the thorntail.runner.webapp-location property to target/<mywebappname> and note that the generated WAR will be invalid. The ZIP will contain all web resource files with the absolute file system path.

      Ex: css / bootstrap.css will be /home/myname/projects/myproject/css/bootstrap.css ...

      Show
      Point the thorntail.runner.webapp-location property to target/ <mywebappname> and note that the generated WAR will be invalid. The ZIP will contain all web resource files with the absolute file system path. Ex: css / bootstrap.css will be /home/myname/projects/myproject/css/bootstrap.css ...

      Description

      Our company is using thorntail for all new microservice projects and we found that using thorntail.runner.webapp-location property an invalid WAR is generated. Attached bug image.

      For productivity reasons, we run the thorntail runner pointing to the target directory. This is very useful when the application has customizations performed at post-packaging time. For example:

      • Maven overlays;
      • Custom Anttasks or scripts.

      We have already found and fixed the problem, the patch is attached (thorntail-custom-webapp-path.diff) and pull request already be sent https://github.com/thorntail/thorntail/pull/1371.

      With this fix, we were able to run the thorntail-runner by taking advantage of the hot-swap of classes and JSPs at run time in the IDE with all the complete post-packaging steps that a Maven project in any IDE already supports.

      We hope you enjoy the patch with the fix.

      Long live Thorntail!

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                lthon Ladislav Thon
                Reporter:
                franklin-1 Franklin Ronald
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: