Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-9459

GitLab commit status shows "running" instead of "pending" when waiting for /ok-to-test approval

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Normal Normal
    • None
    • None
    • Pipelines as Code
    • None

      Description of problem:

      When a Merge Request from a fork requires /ok-to-test approval, GitLab incorrectly displays "Pipeline running" instead of "Pipeline pending". Additionally, the initial "Pipelines as Code CI" status (without pipeline name) is never updated when the actual pipeline starts or completes, leaving it stuck in the pending state.Two issues were identified:

      1. The GitLab provider incorrectly mapped PAC's "pending" conclusion to GitLab's "running" state instead of "pending"
      1. The parent status entry ("Pipelines as Code CI") created during /ok-to-test waiting was never updated when pipeline-specific statuses ("Pipelines as Code CI / <pipeline-name>") were created

      Prerequisites (if any, like setup, operators/versions):

      Steps to Reproduce

       # <steps>

       

      Actual results:

      • GitLab shows "Pipeline #xxx running" when CI is waiting for /ok-to-test approval
      • After /ok-to-test is given and pipeline runs, the parent "Pipelines as Code CI" status remains stuck as pending
      • When pipeline completes, the parent status is not updated to success/failure

      Expected results:

      • GitLab should show "Pipeline pending" when waiting for /ok-to-test approval
      • Parent "Pipelines as Code CI" status should update to "running" when pipeline starts
      • Parent status should update to "success" or "failed" when pipeline completes

      Reproducibility (Always/Intermittent/Only Once):

      Always

      Acceptance criteria: 

      • When waiting for /ok-to-test, GitLab commit status shows "pending" state
      • When pipeline is actively running, GitLab commit status shows "running" state
      • Both parent status ("Pipelines as Code CI") and pipeline-specific status ("Pipelines as Code CI / <name>") are updated together

      Definition of Done:

      Build Details:

      Additional info (Such as Logs, Screenshots, etc):

       

       *

              rh-ee-abghosh Abhishek Ghosh
              rh-ee-abghosh Abhishek Ghosh
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated: