Uploaded image for project: 'OpenShift Pipelines'
  1. OpenShift Pipelines
  2. SRVKP-2056

Ensure that proper labelselectors are used. to query and delete installersets

    XMLWordPrintable

Details

    • Pipelines Sprint 215

    Description

      In TektonAddon Finalizer, the tektonInstallerSet deletion is still done using a list of names from TektonAddon Status. We should be using lableSelectors to do a List query and then delete. (https://github.com/tektoncd/operator/blob/a0cd67e5c428babf1f76316a14cf9c4526055cab/pkg/reconciler/openshift/tektonaddon/tektonaddon.go#L93)

      Eg: https://github.com/tektoncd/operator/blob/a0cd67e5c428babf1f76316a14cf9c4526055cab/pkg/reconciler/kubernetes/tektonpipeline/tektonpipeline.go#L100

      Acceptance Criteria

      • all Finalizer logic uses labelSelector based list queries to find related InstallerSets

      Attachments

        Activity

          People

            smukhade Shivam Mukhade (Inactive)
            rh-ee-nikthoma Nikhil Thomas
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: