• Icon: Sub-task Sub-task
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • None
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False

      What happened?

      The plugin shows the following message when it finishes the execution:

      Wed, 15 Jun 2022 17:32:49 -03> Global Status: running
      JOB_NAME                       | STATUS     | RESULTS    | PROGRESS                  | MESSAGE                                           
      openshift-conformance-validated | running    |            | 2173/2293 (11 failures)   | status=running                                    
      openshift-kube-conformance     | complete   |            | 81/81 (0 failures)        | waiting for post-processor...  

      The state "waiting for post-processor..." comes from MVP CLI but seems not to reflect the real state of the plugin, as when the plugin is in a "completed" state it already run the post-processor.

       

      What did you expect to happen?

      It is an issue from CLI-MVP, but now we could define a better state message to report on new CLI.

      Some options to be used that make more sense to the current state:

      • "Waiting for plugins to finished"
        "Completed. Waiting for the certification environment to be finished"
      • "Completed."

       

            [OPCT-167] [opct] change the state message of plugin completed

            Robert Bost added a comment -

            Robert Bost added a comment - https://github.com/redhat-openshift-ecosystem/provider-certification-tool/pull/8/commits

            Robert Bost added a comment - - edited

            I did add one improvement. When transitioning to the post-processing state, the status will be printed before "Waiting for post-processor" like this:

            Thu, 23 Jun 2022 12:40:22 MDT> Global Status: running
            JOB_NAME                         | STATUS     | RESULTS    | PROGRESS                  | MESSAGE                                           
            openshift-conformance-validated  | running    |            | 10/10 (0 failures)        | status=report-progress-finished                   
            openshift-kube-conformance       | complete   |            | 10/10 (0 failures)        | waiting for post-processor...                     
            Thu, 23 Jun 2022 12:40:32 MDT> Global Status: post-processing
            JOB_NAME                         | STATUS     | RESULTS    | PROGRESS                  | MESSAGE                                           
            openshift-conformance-validated  | complete   |            | 10/10 (0 failures)        | waiting for post-processor...                     
            openshift-kube-conformance       | complete   |            | 10/10 (0 failures)        | waiting for post-processor...                     
            INFO[2022-06-23T12:40:32-06:00] Waiting for post-processor...                
            Thu, 23 Jun 2022 12:43:32 MDT> Global Status: complete
            JOB_NAME                         | STATUS     | RESULTS    | PROGRESS                  | MESSAGE                                           
            openshift-conformance-validated  | complete   | failed     | 10/10 (0 failures)        | Total tests processed: 7 (6 pass / 1 failed)      
            openshift-kube-conformance       | complete   | failed     | 10/10 (0 failures)        | Total tests processed: 13 (12 pass / 1 failed)    
            

            Also, `Sonobuoy pods are ready!` is no longer printed in watch mode.

            Robert Bost added a comment - - edited I did add one improvement. When transitioning to the post-processing state, the status will be printed before "Waiting for post-processor" like this: Thu, 23 Jun 2022 12:40:22 MDT> Global Status: running JOB_NAME | STATUS | RESULTS | PROGRESS | MESSAGE openshift-conformance-validated | running | | 10/10 (0 failures) | status=report-progress-finished openshift-kube-conformance | complete | | 10/10 (0 failures) | waiting for post-processor... Thu, 23 Jun 2022 12:40:32 MDT> Global Status: post-processing JOB_NAME | STATUS | RESULTS | PROGRESS | MESSAGE openshift-conformance-validated | complete | | 10/10 (0 failures) | waiting for post-processor... openshift-kube-conformance | complete | | 10/10 (0 failures) | waiting for post-processor... INFO[2022-06-23T12:40:32-06:00] Waiting for post-processor... Thu, 23 Jun 2022 12:43:32 MDT> Global Status: complete JOB_NAME | STATUS | RESULTS | PROGRESS | MESSAGE openshift-conformance-validated | complete | failed | 10/10 (0 failures) | Total tests processed: 7 (6 pass / 1 failed) openshift-kube-conformance | complete | failed | 10/10 (0 failures) | Total tests processed: 13 (12 pass / 1 failed) Also, `Sonobuoy pods are ready!` is no longer printed in watch mode.

            Robert Bost added a comment - - edited

            I'm not able to reproduce this issue using `openshift-provider-cert run -w` and watching until completion:

            Thu, 23 Jun 2022 10:14:22 MDT> Global Status: running
            JOB_NAME                         | STATUS     | RESULTS    | PROGRESS                  | MESSAGE                                           
            openshift-conformance-validated  | running    |            | 10/10 (0 failures)        | status=running                                    
            openshift-kube-conformance       | complete   |            | 10/10 (0 failures)        | waiting for post-processor...                     
            INFO[2022-06-23T10:14:32-06:00] Waiting for post-processor...                
            Thu, 23 Jun 2022 10:17:42 MDT> Global Status: complete
            JOB_NAME                         | STATUS     | RESULTS    | PROGRESS                  | MESSAGE                                           
            openshift-conformance-validated  | complete   | failed     | 10/10 (0 failures)        | Total tests processed: 6 (5 pass / 1 failed)      
            openshift-kube-conformance       | complete   | failed     | 10/10 (0 failures)        | Total tests processed: 13 (12 pass / 1 failed)    
            INFO[2022-06-23T10:17:42-06:00] Sonobuoy pods are ready!                     
            

            rhn-support-mrbraga let's catch up on Slack when you are back in office.

            Robert Bost added a comment - - edited I'm not able to reproduce this issue using `openshift-provider-cert run -w` and watching until completion: Thu, 23 Jun 2022 10:14:22 MDT> Global Status: running JOB_NAME | STATUS | RESULTS | PROGRESS | MESSAGE openshift-conformance-validated | running | | 10/10 (0 failures) | status=running openshift-kube-conformance | complete | | 10/10 (0 failures) | waiting for post-processor... INFO[2022-06-23T10:14:32-06:00] Waiting for post-processor... Thu, 23 Jun 2022 10:17:42 MDT> Global Status: complete JOB_NAME | STATUS | RESULTS | PROGRESS | MESSAGE openshift-conformance-validated | complete | failed | 10/10 (0 failures) | Total tests processed: 6 (5 pass / 1 failed) openshift-kube-conformance | complete | failed | 10/10 (0 failures) | Total tests processed: 13 (12 pass / 1 failed) INFO[2022-06-23T10:17:42-06:00] Sonobuoy pods are ready! rhn-support-mrbraga let's catch up on Slack when you are back in office.

              rhn-support-rbost Robert Bost
              rhn-support-mrbraga Marco Braga
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: