Uploaded image for project: 'Red Hat Developer Hub Bugs'
  1. Red Hat Developer Hub Bugs
  2. RHDHBUGS-634

refactor PluginPermissionMetadataCollector constructor

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • Permissions
    • None
    • 1
    • False
    • Hide

      None

      Show
      None
    • False

      Description of problem:

      Tech Debt: Triggered by this disucssion under this PR to migrate RBAC plugin to use the new backend.

      Actual results:

      The current constructor implementation uses optional argument UrlReader and this method is not great for readability. 

       

        constructor(
          private readonly discovery: DiscoveryService,
          private readonly pluginIdProvider: PluginIdProvider,
          private readonly logger: LoggerService,
          config: Config,
          urlReader?: UrlReaderService, 
        )

       

      Expected results:

      Use 2 objects as the arguments instead: `deps` for mandatory parameters and `optional` for optional ones.

      Reproducibility (Always/Intermittent/Only Once):

      Always

              rh-ee-jhe Jessica He
              rh-ee-jhe Jessica He
              RHDH Plugins
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: