Uploaded image for project: 'RichFaces Planning'
  1. RichFaces Planning
  2. RFPL-3506

File an upstream issue for the Mojarra uiRepeat#setIndex issue

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

    XMLWordPrintable

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Done
    • None
    • 4.5.0.CR1
    • third-party
    • None
    • 4.5.0.CR2 - Sprint 1

    Description

      I reverted the change introduced by JAVASERVERFACES-3152 and rebuilt mojarra 2.2.6. Replacing the jsf-impl jar with this new one in WildFly 8.1 resolved the problem, so I can confirm this issue is caused by JAVASERVERFACES-3152.

      The relevant change in JAVASERVERFACES-3152 is:

      ----------------------------
      Index: jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java
      ===================================================================
      --- jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java	(revision 12814)
      +++ jsf-ri/src/main/java/com/sun/faces/facelets/component/UIRepeat.java	(working copy)
      @@ -787,7 +787,9 @@
               // Just need to check whether there are any ids under this
               // subtree.  Make sure row index is cleared out since
               // getSubtreeIdsToVisit() needs our row-less client id.
      -        setIndex(context.getFacesContext(), -1);
      +        if (requiresRowIteration(context)) {
      +            setIndex(context.getFacesContext(), -1);
      +        }
               Collection<String> idsToVisit = context.getSubtreeIdsToVisit(this);
               assert(idsToVisit != null);
      

      and it's meant to address:

      <ui:repeat>'s value attribute gets evaluated during each and every ajax call, even when <ui:repeat> is outside the render area

      A number of RF components are broken with this bug, they are labelled with the uiRepeat:setIndex tag:

      https://issues.jboss.org/browse/RF-13801?jql=labels%20%3D%20%22uiRepeat%23setIndex%22

      Attachments

        Issue Links

          Activity

            People

              mpetrov@redhat.com Michal Petrov
              bleathem@redhat.com Brian Leathem (Inactive)
              Archiver:
              samahaja@redhat.com Sagar Mahajan

              Dates

                Created:
                Updated:
                Resolved:
                Archived:

                Time Tracking

                  Estimated:
                  Original Estimate - 1 day
                  1d
                  Remaining:
                  Remaining Estimate - 1 day
                  1d
                  Logged:
                  Time Spent - Not Specified
                  Not Specified