Uploaded image for project: 'RichFaces'
  1. RichFaces
  2. RF-13947

CDK generates code overriding encodeEnd

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Blocker
    • Resolution: Rejected
    • Affects Version/s: 4.5.0.Final
    • Fix Version/s: None
    • Component/s: cdk
    • Labels:
      None
    • Steps to Reproduce:
      Hide

      define the .template.xml at:

      <cdk:superclass>some.package.SomeRendererBase</cdksuperclass>

      and SomeRendererBase as:

      public class SomeRendererBase extends RendererBase

      The result "SomeRenderer" code wil try to override "encodeEnd" and the build will abort with message "encodeEnd(FacesContext,UIComponent) in SomeRenderer cannot override encodeEnd(FacesContext,UIComponent) in RendererBase"

      Show
      define the .template.xml at: <cdk:superclass>some.package.SomeRendererBase</cdksuperclass> and SomeRendererBase as: public class SomeRendererBase extends RendererBase The result "SomeRenderer" code wil try to override "encodeEnd" and the build will abort with message "encodeEnd(FacesContext,UIComponent) in SomeRenderer cannot override encodeEnd(FacesContext,UIComponent) in RendererBase"

      Description

      As RendererBase method "encodeEnd" is defined as final in richfaces-4.5.1 (probably derived from RF-13494), cdk should not generate code that overrides that method (instead, should overrides "doEncodeEnd").

      It always happening when the <cdk:superclass> is a class that extends RendererBase (it doesn't happen when the superclass is RendererBase itself).

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                farrer Guilherme Farrer
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: