Uploaded image for project: 'RichFaces'
  1. RichFaces
  2. RF-13538

Closeables.closeQuietly() removed in Guava 16.0, but still used in RF

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Duplicate Issue
    • Affects Version/s: 5.0.0.Alpha3
    • Fix Version/s: None
    • Component/s: core
    • Labels:
      None

      Description

      For instance in org.richfaces.resource.Java2DUserResourceWrapperImpl at line 73 is an invocation of Closeables.closeQuietly(...). However, this method is removed in Guava 16.0 which is now used in RF 5.0.0.Alpha3.

      javadoc of Guava 14.0 already mentioned:
      "Deprecated. Where possible, use the try-with-resources statement if using JDK7 or Closer on JDK6 to close one or more Closeable objects. This method is deprecated because it is easy to misuse and may swallow IO exceptions that really should be thrown and handled. See Guava issue 1118 for a more detailed explanation of the reasons for deprecation and see Closing Resources for more information on the problems with closing Closeable objects and some of the preferred solutions for handling it correctly. This method is scheduled to be removed in Guava 16.0."
      Well, now the method is removed, but still invoked in RF 5.0.0.Alpha3.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Assignee:
                  lfryc Lukáš Fryč
                  Reporter:
                  juergen.zimmermann Juergen Zimmermann
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved: